Sync up to main repo

.coveragerc

@@ -5,9 +5,8 @@ source =
 
 [paths]
 source =
-   src/attr
-   .tox/*/lib/python*/site-packages/attr
-   .tox/pypy/site-packages/attr
+   src
+   .tox/*/site-packages
 
 [report]
 show_missing = True

.github/CONTRIBUTING.rst

@@ -68,7 +68,7 @@ Tests
      assert "foo" == x._a_private_attribute
 
 - To run the test suite, all you need is a recent tox_.
-  It will ensure the test suite runs with all dependencies against all Python versions just as it will on Travis CI.
+  It will ensure the test suite runs with all dependencies against all Python versions just as it will in our CI.
   If you lack some Python versions, you can can always limit the environments like ``tox -e py27,py35`` (in that case you may want to look into pyenv_, which makes it very easy to install many different Python versions in parallel).
 - Write `good test docstrings`_.
 - To ensure new features work well with the rest of the system, they should be also added to our `Hypothesis`_ testing strategy, which is found in ``tests/strategies.py``.
@@ -238,10 +238,10 @@ Thank you for considering contributing to ``attrs``!
 .. _tox: https://tox.readthedocs.io/
 .. _pyenv: https://github.com/pyenv/pyenv
 .. _reStructuredText: https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html
-.. _semantic newlines: http://rhodesmill.org/brandon/2012/one-sentence-per-line/
+.. _semantic newlines: https://rhodesmill.org/brandon/2012/one-sentence-per-line/
 .. _examples page: https://github.com/python-attrs/attrs/blob/master/docs/examples.rst
 .. _Hypothesis: https://hypothesis.readthedocs.io/
-.. _CI: https://travis-ci.org/python-attrs/attrs/
+.. _CI: https://attrs.visualstudio.com/attrs/_build/latest?definitionId=1&branchName=master
 .. _`team of volunteers`: https://github.com/python-attrs
 .. _BDFL: https://en.wikipedia.org/wiki/Benevolent_dictator_for_life
 .. _towncrier: https://pypi.org/project/towncrier

.github/PULL_REQUEST_TEMPLATE.md

@@ -12,7 +12,7 @@ If an item doesn't apply to your pull request, **check it anyway** to make it ap
     - [ ] New functions/classes have to be added to `docs/api.rst` by hand.
     - [ ] Changes to the signature of `@attr.s()` have to be added by hand too.
     - [ ] Changed/added classes/methods/functions have appropriate `versionadded`, `versionchanged`, or `deprecated` [directives](http://www.sphinx-doc.org/en/stable/markup/para.html#directive-versionadded).
-- [ ] Documentation in `.rst` files is written using [semantic newlines](http://rhodesmill.org/brandon/2012/one-sentence-per-line/).
+- [ ] Documentation in `.rst` files is written using [semantic newlines](https://rhodesmill.org/brandon/2012/one-sentence-per-line/).
 - [ ] Changes (and possible deprecations) have news fragments in [`changelog.d`](https://github.com/python-attrs/attrs/blob/master/changelog.d).
 
 If you have *any* questions to *any* of the points above, just **submit and ask**!  This checklist is here to *help* you, not to deter you from contributing!

.gitignore

@@ -1,5 +1,5 @@
-*.pyc
 *.egg-info
+*.pyc
 .cache
 .coverage*
 .hypothesis
@@ -10,3 +10,4 @@ build
 dist
 docs/_build/
 htmlcov
+pip-wheel-metadata

.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 repos:
   - repo: https://github.com/ambv/black
-    rev: 18.9b0
+    rev: 19.3b0
     hooks:
       - id: black
         language_version: python3.7
@@ -9,24 +9,24 @@ repos:
         types: []
 
   - repo: https://gitlab.com/pycqa/flake8
-    rev: '3.7.3'
+    rev: 3.7.7
     hooks:
     - id: flake8
       language_version: python3.7
 
   - repo: https://github.com/asottile/seed-isort-config
-    rev: v1.5.0
+    rev: v1.9.1
     hooks:
       - id: seed-isort-config
 
   - repo: https://github.com/pre-commit/mirrors-isort
-    rev: v4.3.4
+    rev: v4.3.20
     hooks:
       - id: isort
         language_version: python3.7
 
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v2.1.0
+    rev: v2.2.3
     hooks:
       - id: trailing-whitespace
       - id: end-of-file-fixer

.readthedocs.yml

@@ -1,6 +1,10 @@
 ---
+version: 2
 python:
-  version: 3
-  pip_install: true
-  extra_requirements:
-    - docs
+  version: 3.7
+
+  install:
+    - method: pip
+      path: .
+      extra_requirements:
+        - docs

CHANGELOG.rst

@@ -15,6 +15,49 @@ Changes for the upcoming release can be found in the `"changelog.d" directory <h
 
 .. towncrier release notes start
 
+19.1.0 (2019-03-03)
+-------------------
+
+Backward-incompatible Changes
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+- Fixed a bug where deserialized objects with ``cache_hash=True`` could have incorrect hash code values.
+  This change breaks classes with ``cache_hash=True`` when a custom ``__setstate__`` is present.
+  An exception will be thrown when applying the ``attrs`` annotation to such a class.
+  This limitation is tracked in issue `#494 <https://github.com/python-attrs/attrs/issues/494>`_.
+  `#482 <https://github.com/python-attrs/attrs/issues/482>`_
+
+
+Changes
+^^^^^^^
+
+- Add ``is_callable``, ``deep_iterable``, and ``deep_mapping`` validators.
+
+  * ``is_callable``: validates that a value is callable
+  * ``deep_iterable``: Allows recursion down into an iterable,
+    applying another validator to every member in the iterable
+    as well as applying an optional validator to the iterable itself.
+  * ``deep_mapping``: Allows recursion down into the items in a mapping object,
+    applying a key validator and a value validator to the key and value in every item.
+    Also applies an optional validator to the mapping object itself.
+
+  You can find them in the ``attr.validators`` package.
+  `#425 <https://github.com/python-attrs/attrs/issues/425>`_
+- Fixed stub files to prevent errors raised by mypy's ``disallow_any_generics = True`` option.
+  `#443 <https://github.com/python-attrs/attrs/issues/443>`_
+- Attributes with ``init=False`` now can follow after ``kw_only=True`` attributes.
+  `#450 <https://github.com/python-attrs/attrs/issues/450>`_
+- ``attrs`` now has first class support for defining exception classes.
+
+  If you define a class using ``@attr.s(auto_exc=True)`` and subclass an exception, the class will behave like a well-behaved exception class including an appropriate ``__str__`` method, and all attributes additionally available in an ``args`` attribute.
+  `#500 <https://github.com/python-attrs/attrs/issues/500>`_
+- Clarified documentation for hashing to warn that hashable objects should be deeply immutable (in their usage, even if this is not enforced).
+  `#503 <https://github.com/python-attrs/attrs/issues/503>`_
+
+
+----
+
+
 18.2.0 (2018-09-01)
 -------------------
 

README.rst

@@ -9,8 +9,8 @@
    :target: https://www.attrs.org/en/stable/?badge=stable
    :alt: Documentation Status
 
-.. image:: https://travis-ci.org/python-attrs/attrs.svg?branch=master
-   :target: https://travis-ci.org/python-attrs/attrs
+.. image:: https://attrs.visualstudio.com/attrs/_apis/build/status/python-attrs.attrs?branchName=master
+   :target: https://attrs.visualstudio.com/attrs/_build/latest?definitionId=1&branchName=master
    :alt: CI Status
 
 .. image:: https://codecov.io/github/python-attrs/attrs/branch/master/graph/badge.svg
@@ -101,7 +101,7 @@ Testimonials
   It exerts a subtle, but positive, design influence in all the codebases I’ve see it used in.
 
 
-**Kenneth Reitz**, author of `Requests <http://www.python-requests.org/>`_ and Developer Advocate at DigitalOcean, (`on paper no less <https://twitter.com/hynek/status/866817877650751488>`_!):
+**Kenneth Reitz**, author of `Requests <http://www.python-requests.org/>`_ (`on paper no less <https://twitter.com/hynek/status/866817877650751488>`_!):
 
   attrs—classes for humans.  I like it.
 

azure-pipelines.yml

@@ -0,0 +1,114 @@
+---
+trigger:
+  - master
+
+jobs:
+  - job: 'Test'
+    pool:
+      vmImage: 'ubuntu-latest'
+    strategy:
+      matrix:
+        Typing:
+          python.version: '3.7'
+          tox.env: typing
+        Lint:
+          python.version: '3.7'
+          tox.env: lint
+
+        py27:
+          python.version: '2.7'
+          tox.env: py27
+        py34:
+          python.version: '3.4'
+          tox.env: py34
+        py35:
+          python.version: '3.5'
+          tox.env: py35
+        py36:
+          python.version: '3.6'
+          tox.env: py36
+        py37:
+          python.version: '3.7'
+          tox.env: py37
+        py38:
+          python.version: '3.8'
+          tox.env: py38
+
+        pypy2:
+          python.version: 'pypy2'
+          tox.env: pypy
+        pypy3:
+          python.version: 'pypy3'
+          tox.env: pypy3
+
+
+        Docs:
+          python.version: '3.7'
+          tox.env: docs
+        PyPI-Description:
+          python.version: '3.7'
+          tox.env: pypi-description
+        Changelog:
+          python.version: '3.7'
+          tox.env: changelog
+
+    steps:
+      - task: UsePythonVersion@0
+        displayName: Get Python for Python tools.
+        inputs:
+          versionSpec: '3.6'
+          addToPath: false
+        name: pyTools
+
+      - script: $(pyTools.pythonLocation)/bin/pip install --upgrade tox
+        displayName: Install Python-based tools.
+
+      - task: UsePythonVersion@0
+        inputs:
+          versionSpec: '$(python.version)'
+          architecture: 'x64'
+        condition: not(in(variables['python.version'], '3.7', '3.8'))
+        displayName: Use cached Python $(python.version) for tests.
+
+      - script: |
+          sudo add-apt-repository ppa:deadsnakes
+          sudo apt-get update
+          sudo apt-get install -y --no-install-recommends python$(python.version)-dev python$(python.version)-distutils
+        condition: in(variables['python.version'], '3.7', '3.8')
+        displayName: Install Python $(python.version) from the deadsnakes PPA for tests.
+
+      - script: $(pyTools.pythonLocation)/bin/tox -e $(tox.env)
+        env:
+          TOX_AP_TEST_EXTRAS: azure-pipelines
+        displayName: run tox -e $(tox.env)
+
+      - script: |
+          if [ ! -f .coverage.* ]; then
+            echo No coverage data found.
+            exit 0
+          fi
+
+          # codecov shells out to "coverage" and avoiding 'sudo pip' allows for
+          # package caching.
+          PATH=$HOME/.local/bin:$PATH
+
+          case "$(python.version)" in
+          "pypy2") PY=pypy ;;
+          "pypy3") PY=pypy3 ;;
+          *) PY=python$(python.version) ;;
+          esac
+
+          # Python 3.8 needs an up-to-date pip.
+          if [ "$(python.version)" = "3.8" ]; then
+            curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py
+            $PY get-pip.py --user
+          fi
+
+          $PY -m pip install --user coverage codecov
+
+          coverage combine
+          codecov
+        env:
+          CODECOV_TOKEN: $(codecov.token)
+        displayName: Report Coverage
+        condition: succeeded()

changelog.d/504.breaking.rst

@@ -0,0 +1,2 @@
+Removed deprecated ``Attribute`` attribute ``convert`` per scheduled removal on 2019/1.
+This planned deprecation is tracked in issue `#307 <https://github.com/python-attrs/attrs/issues/307>`_.

changelog.d/517.bugfix.rst

@@ -0,0 +1 @@
+Updated ``attr.validators.__all__`` to include new validators added in `#425 <https://github.com/python-attrs/attrs/pull/425>`_.

changelog.d/522.change.rst

@@ -0,0 +1 @@
+Slotted classes now use a pure Python mechanism to rewrite the ``__class__`` cell when rebuilding the class, so ``super()`` works even on environments where ``ctypes`` is not installed.