This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Hotfix/examples #198
Merged
Hotfix/examples #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e9e6f8f.
sdelatorrep
suggested changes
Jun 20, 2018
There was a problem hiding this comment.
There are parsing errors because the paths are wrong.
Please, fix also the path with the CC definition. The correct one is: https://raw.githubusercontent.com/ga4gh/ga4gh-consent-policy/806ea53cffacb2055c3639f0fc9783f0dcd8cb02/consent_code.yaml#/components/schemas/ConsentCodeDataUse
beacon.yaml
Outdated
| @@ -646,13 +646,13 @@ components: | |||
| properties: | |||
| header: | |||
| $ref: >- | |||
| https://raw.githubusercontent.com/ga4gh/ADA-M/b16a72f9987ae20f433e97d6a3247ecddd8dde23/adam.yaml#/definitions/AdamHeader | |||
| https://raw.githubusercontent.com/ga4gh/ADA-M/b16a72f9987ae20f433e97d6a3247ecddd8dde23/adam.yaml#/definitions/Header | |||
There was a problem hiding this comment.
beacon.yaml
Outdated
| profile: | ||
| $ref: >- | ||
| https://raw.githubusercontent.com/ga4gh/ADA-M/b16a72f9987ae20f433e97d6a3247ecddd8dde23/adam.yaml#definitions/AdamProfile | ||
| https://raw.githubusercontent.com/ga4gh/ADA-M/b16a72f9987ae20f433e97d6a3247ecddd8dde23/adam.yaml#/definitions/Profile |
There was a problem hiding this comment.
beacon.yaml
Outdated
| terms: | ||
| $ref: >- | ||
| https://raw.githubusercontent.com/ga4gh/ADA-M/b16a72f9987ae20f433e97d6a3247ecddd8dde23/adam.yaml#/definitions/AdamTerms | ||
| https://raw.githubusercontent.com/ga4gh/ADA-M/b16a72f9987ae20f433e97d6a3247ecddd8dde23/adam.yaml#/definitions/Terms |
There was a problem hiding this comment.
beacon.yaml
Outdated
| metaConditions: | ||
| $ref: >- | ||
| https://raw.githubusercontent.com/ga4gh/ADA-M/b16a72f9987ae20f433e97d6a3247ecddd8dde23/adam.yaml#/definitions/AdamMetaConditions | ||
| https://raw.githubusercontent.com/ga4gh/ADA-M/b16a72f9987ae20f433e97d6a3247ecddd8dde23/adam.yaml#/definitions/MetaConditions |
There was a problem hiding this comment.
sdelatorrep
approved these changes
Jun 20, 2018
garysaunders
approved these changes
Jun 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is hot fix for bugs caused by #165 and #139. In #165 we used "examples" keyword with properties which is not supported and in #139 we referred to objects which didn't exist in ADA-M.