Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Describe how to query without reference bases #59

Closed
mcupak opened this issue Jul 27, 2016 · 13 comments
Closed

Describe how to query without reference bases #59

mcupak opened this issue Jul 27, 2016 · 13 comments
Assignees
Milestone

Comments

@mcupak
Copy link
Contributor

mcupak commented Jul 27, 2016

The spec requires specifying referenceBases and alternateBases. Some beacons don't store reference bases. Is this a case that should be supported by the spec? If so, should we consider making the parameter optional?

@mcupak mcupak added this to the 1.x milestone Jul 27, 2016
@antbro
Copy link

antbro commented Jul 27, 2016

+1

Miro Cupak wrote:

The spec requires specifying |referenceBases| and |alternateBases|.
Some beacons don't store reference bases. Is this a case that should
be supported by the spec? If so, should we consider making the
parameter optional?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#59, or mute the thread
https://github.com/notifications/unsubscribe-auth/AI_EVFL0pGTJnWKnOuuYwRiAkesspWkRks5qZ6KpgaJpZM4JWe8v.

@jrambla
Copy link
Collaborator

jrambla commented Aug 1, 2016

+1

@mitsuhashi
Copy link

+1

Hi Miro,
Thanks for sparing your time at GA4GH 4th plenary meeting.

Nobutaka

@mbaudis
Copy link
Member

mbaudis commented Dec 13, 2016

+1

@sdelatorrep
Copy link
Contributor

+1 to include this in v0.4

@sdelatorrep sdelatorrep modified the milestones: 0.4, 1.x May 2, 2017
sdelatorrep added a commit to sdelatorrep/beacon-team that referenced this issue May 2, 2017
@antbro antbro mentioned this issue May 2, 2017
Merged
@mcupak
Copy link
Contributor Author

mcupak commented May 24, 2017

This proposal was discussed during the workshop yesterday and rejected. Reference bases remain a mandatory parameter as it is easy to fetch the reference for beacons that don't store it in the database directly.

@mcupak mcupak closed this as completed May 24, 2017
@mbaudis
Copy link
Member

mbaudis commented May 24, 2017 via email

@antbro
Copy link

antbro commented May 24, 2017 via email

@mbaudis
Copy link
Member

mbaudis commented May 24, 2017

@antbro I think the "if one of the end" positions makes this explicit. I'm anyway for optional, but this seems a good solution - if you specify an end, you fulfil a specific requirement.

@antbro
Copy link

antbro commented May 24, 2017 via email

@mbaudis
Copy link
Member

mbaudis commented May 24, 2017

I do not understand why this is influenced by (or guided by) whether or
not we are searching within a precise start-end region or a fuzzy region

The "if end, then no ref needed..." proposal is independent of fuzziness (aka imprecision ...). It is just "you provide the sequence being altered, OR you give the coordinates".

And if end == start, you solve the reference requirement in a sneaky but explicit way even for single bases.

So, while I understand the specification of reference_bases for single replacements, and understand the current use for small dels (ref >> alt; e.g. ref ATCGTA, alt A == deletion of 5 bases), I'm not particularly fond of it; but there are sensible ways to query around this if implementing the "if not ref than end else fail" paradigm.

(I'm the mediator here, right?)

@mbaudis
Copy link
Member

mbaudis commented May 29, 2017

@mcupak Re-opening. There was general consensus before to make reference_bases optional, so this needs explanation.

This proposal was discussed during the workshop yesterday and rejected. Reference bases remain a mandatory parameter as it is easy to fetch the reference for beacons that don't store it in the database directly.

Reference bases have to be optional for imprecise and range queries, and per se only apply to SNV/small indels. So they only are specified when

  • an exact position is being queried
  • alternate_bases are being provided

In summary this needs a documentation about these conditional interpretations.

@mbaudis
Copy link
Member

mbaudis commented Sep 12, 2017

Closing this, since in documentation now "N" allele documented as permitted value for unknown, which solves this (if interpreted as "any").

@mbaudis mbaudis closed this as completed Sep 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants