Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Is end inclusive or exclusive? #202

Closed
sdelatorrep opened this issue Jul 12, 2018 · 4 comments
Closed

Is end inclusive or exclusive? #202

sdelatorrep opened this issue Jul 12, 2018 · 4 comments

Comments

@sdelatorrep
Copy link
Contributor

One may assume it's inclusive because of this sentence in the spec (description of start parameter):

  • start and end:
    • special use case for exactly determined structural changes

but this assumption may be wrong. We must say it explicitly if it's inclusive or not.

@mbaudis
Copy link
Member

mbaudis commented Jul 12, 2018

The coordinate system that should be used throughout GA4GH standards is 0-based half open. So in a sequence of

ACCGTCGA

... the exact match for GTC would be

start: 3,
end: 6

... due to interbase coordinates.

I think we (...) have to fix this in the Wiki, which isn't correct for some of the positions...

(edited the error after comments by @sdelatorrep and @antbro ...)

@sdelatorrep
Copy link
Contributor Author

mmmm I see. Then it's not clear at all in the spec.
What are interbase coordinates? Shouldn't it be start=3 as it's 0-based (so the G is at position 3) and end=6?

@antbro
Copy link

antbro commented Jul 12, 2018 via email

@mbaudis
Copy link
Member

mbaudis commented Jul 12, 2018

@sdelatorrep & @antbro O.k.; can we roll this back, please? It is, obviously, counted base -1, when talking about the positions. I had shortened an example I was using & didn't shift ...

Does the internet forget?

sdelatorrep added a commit that referenced this issue Jul 30, 2018
juhtornr added a commit that referenced this issue Aug 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants