Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Consolidate API versions #150

Closed
mcupak opened this issue Mar 25, 2018 · 2 comments
Closed

Consolidate API versions #150

mcupak opened this issue Mar 25, 2018 · 2 comments
Assignees
Labels
theme:DevEnv Beacon Development Environment theme:GA4GH-1.0 type:bug
Milestone

Comments

@mcupak
Copy link
Contributor

mcupak commented Mar 25, 2018

The API consists of 2 files - beacon.yaml and openapi.yaml, which contain conflicting versions under info/version (1.0.0 vs. 0.4.0).

@mcupak mcupak added type:bug theme:DevEnv Beacon Development Environment labels Mar 25, 2018
@mcupak mcupak added this to the 0.4.1 milestone Mar 25, 2018
@mcupak
Copy link
Contributor Author

mcupak commented Mar 25, 2018

The files are actually not that large - should we just merge them into a single file to avoid this problem?

Also, should we distinguished between released and developed versions? E.g. similarly to what Maven does with -SNAPSHOT.

@sdelatorrep
Copy link
Contributor

sdelatorrep commented Mar 26, 2018

We split into 2 files for clarification (paths in a file and definitions in another) but it's totally true that they are not that big (around 600 lines in total). We can consider merging.

EDIT: If we merge both files, then #140 can be closed as it would not apply anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme:DevEnv Beacon Development Environment theme:GA4GH-1.0 type:bug
Projects
None yet
Development

No branches or pull requests

2 participants