Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding isAggregator flag #53

Closed
wants to merge 3 commits into from
Closed

adding isAggregator flag #53

wants to merge 3 commits into from

Conversation

mbaudis
Copy link
Member

@mbaudis mbaudis commented Dec 21, 2022

This commit adds an optional isAggregator flag to beaconResponseMeta which will allow especially aggregators to avoid duplications & loops.

This commit adds an optional `isAggregator` flag to `beaconResponseMeta` which will allow especially aggregators to avoid duplications & loops.
@mbaudis mbaudis added this to the 2.0.1 milestone Dec 21, 2022
@mbaudis
Copy link
Member Author

mbaudis commented Dec 21, 2022

... and this is a non-breaking addition so no delay necessary.

@redmitry
Copy link
Collaborator

Would it be better to put it in the beaconInformationalResponseMeta?
I mean that if the endpoint is an aggregator all its beaconResponseMeta are also isAggregator?

Other thing is to distinguish resultsets, but in this case it should be per resultset (ResultsetInstance)?

Dmitry

@mbaudis
Copy link
Member Author

mbaudis commented Dec 21, 2022

@redmitry Good point; added it to beaconInformationalResponseMeta in 4a6efe8

But it should also stay in the normal responses since otherwise it could only be accessed w/ multiple passes.

Resultsets: The idea is that all resultSets are treated equally; i.e. an aggregator will concatenate the ResultsetInstance objects from different Beacons in its resultSets. With that we don't introduce another layer or type of response. However, it would be helpful here to have some dedicated source parameter which indicates the originating beacon.

@redmitry
Copy link
Collaborator

it would be helpful here to have some dedicated source parameter which indicates the originating beacon.
Agree. Ideally it should contain the beacon identifier that originated the result set.
Something like "source": beaconId

@mbaudis
Copy link
Member Author

mbaudis commented Dec 21, 2022

@redmitry Like this 9ae6447 ?

@mbaudis mbaudis force-pushed the meta-add-aggregator-flag branch from 85e2951 to 9ae6447 Compare December 21, 2022 12:13
@redmitry
Copy link
Collaborator

redmitry commented Dec 21, 2022

@redmitry Like this 3f25a45 ?

Yes

@costero-e costero-e closed this Mar 28, 2023
@costero-e costero-e deleted the meta-add-aggregator-flag branch March 28, 2023 11:04
@costero-e costero-e restored the meta-add-aggregator-flag branch March 28, 2023 11:14
@costero-e costero-e reopened this Mar 28, 2023
@costero-e costero-e closed this Mar 28, 2023
@costero-e costero-e deleted the meta-add-aggregator-flag branch March 28, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants