fixing requestParameters schema for genomicVariations #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like the correct structure but needs to be filled in for the correct references (filters etc.)
... other parameters then to be added later.
mbaudis
changed the title
|
IMO should be merged in as fix of the wrongly formatted schema. w/o need to hold back. |
mbaudis
added a commit
that referenced
this pull request
Aug 15, 2022
In the Beacon v2 default model, the variant request parameters for the query documents (i.e. POST queries) are wrapped in the `g_variant` object. While this ATM is incorrectly formatted (see proposed fix in #47) the intention is now visible here in the query documents for v2 POST examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like the correct structure but needs to be filled in for the correct references (filters etc.)
While this fixes the wrong
g_variantsroot parameter the PR is mostly the basis for discussion & expansion.This then also needs to be transferred to the JSON version, after editing is finished.