Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot Fix to align with json #132

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

mbaudis
Copy link
Member

@mbaudis mbaudis commented Jul 6, 2024

The last fix for the wrong level of required was only done in json... Please always add src first since (well, both).

The last fix for the wrong level of `required` was only done in json... Please always add `src` first since (well, both).
@mbaudis mbaudis requested review from redmitry and costero-e July 6, 2024 13:52
Copy link
Collaborator

@costero-e costero-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mbaudis ! Thank you for this. Yes, my bad, this was meant to be added along with #124.

@costero-e costero-e requested a review from jrambla July 10, 2024 12:10
@costero-e costero-e merged commit 4db7f83 into main Jul 10, 2024
1 check passed
@costero-e costero-e deleted the complex-value-required-src-hotfix branch July 16, 2024 07:45
@costero-e costero-e added this to the 2.1 milestone Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants