-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiscope to main branch #118
Conversation
add scopes[] to the FilteringTerm
@@ -46,6 +46,14 @@ definitions: | |||
examples: | |||
- 'B Lymphoblastic Leukemia/Lymphoma' | |||
- 'Aplasia/Hypoplasia of the middle ear' | |||
scopes: | |||
description: >- | |||
Entry types this filter may be applied to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Entry types affected by this filter" since then we accommodate for query aggregation.
description: >- | ||
Entry types this filter may be applied to. | ||
examples: | ||
- '["individual", "biosample"]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... and making this multi-scope clear by example:
examples:
- - individual
- biosample
- analysis
- run
- genomicVariation
- - biosample
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, with wish for change in wording (see inline comment).
Also, for a clean schema it would be good if the possible scopes could be derived from somewhere (i.e. defined in the model & retrieved...). Or we could make it a hard coded enum - but these are, comments, not requirements.
The scopes are entryTypes, So beacon provider may have its own types and associated filters... examples:
- - individual
- biosample
- analysis
- run
- genomicVariation
- - biosample I am not sure... is it valid??? I would prefer: examples:
- [individual, biosample, analysis, run, genomicVariation]
- [biosample] |
(I find this version more confusing since especially w/ 2 space indentation it doesn't look that clear - but YMMV). |
should be an array of arrays...
…msResults Filtering terms results examples listed following tendency
Changes you requested have been applied @mbaudis. If you want to review again. Thank you. |
... and it looks like that for us: http://progenetix.org/beacon/filtering_terms/?testMode=true |
Hello,
as we are already implementing beacons with this accepted work in filtering terms scope, which now becomes an array of scopes, I was feeling the need to make it official, hence I am merging it to main branch. Also, I think it is good to already show it in main branch for further discussions.
Let me know what you think. Thank you.