AddPart - first geometry

[FITCODE1]

Checklist

• I've searched through the current issues to make sure this feature hasn't been requested already.

Motivation

Hi,

I searched through the G3W functionalities and documentation for possibility of adding first geometry to a feature in G3W, exception of Add Part to Multipart - Screenshot01. Also I've searched through the GIT issues to make sure this feature hasn't been requested already. I hope I didn't miss something. If so, I apologize in advance.

In the scenario where I import features without geometry into a QGIS layer, is there a possibility to add first geometry to from G3W Client, function similar to AddPart from QGIS (Screenshot02)? If not, I would like to know

1. it is possible to develop this feature?
2. when it could be available?

Regars,

Alin

Suggested solution

Adding an AddPart button next to the already existing Add part to multipart button .

Usage Flow:
Step 1. The user will select the feature of interest from the Attributes Table
Step 2. Select the AddPart button
Step 3. Draw point / line / polygon.
Step 4. Saving change ,

That geometry will be automatically associated with the previously selected feature.

Alternatives considered

[volterra79]

@FITCODE1 we evaluate it. Thanks

[Raruto]

Hi @FITCODE1,

1. is is possible to develop this feature?
2. when it could be available?

Next stable G3W-SUITE release is expected to happen in 6 months, so June 2024 (the next one at the end of 2024).

Usually, sponsored features are more likely to be implemented sooner, in this case contact [email protected] to get in touch with the sales department.

Otherwise, just propose your own PR to speed things up.

Below almost all the code that handles the "Add part to multipart" button (you can use that as a starting point to create a your own button):

g3w-client-plugin-editing/toolboxes/toolsfactory.js

Lines 147 to 160 in c7855f3

	...(isMultiGeometry ? [
	{
	config: {
	id: 'addPart',
	name: "editing.tools.addpart",
	icon: "addPart.png",
	layer,
	once: true,
	row: 3,
	op: AddPartToMultigeometriesWorkflow,
	type: ['add_feature', 'change_feature']
	}
	}
	] : []),

g3w-client-plugin-editing/toolboxes/toolsfactory.js

Lines 301 to 314 in c7855f3

	...(isMultiGeometry ? [
	{
	config: {
	id: 'addPart',
	name: "editing.tools.addpart",
	icon: "addPart.png",
	layer,
	row: 3,
	once: true,
	op: AddPartToMultigeometriesWorkflow,
	type: ['add_feature', 'change_feature']
	}
	}
	] : []),

g3w-client-plugin-editing/workflows/addparttomultigeometriesworkflow.js

Lines 1 to 55 in c7855f3

	const { base, inherit } = g3wsdk.core.utils;
	const EditingWorkflow = require('./editingworkflow');
	const PickFeatureStep = require('./steps/pickfeaturestep');
	const ChooseFeatureStep = require('./steps/choosefeaturestep');
	const AddFeatureStep = require('./steps/addfeaturestep');
	const AddPartToMultigeometriesStep = require('./steps/addparttomultigeometriesstep');
	function AddPartToMultigeometriesWorflow(options={}) {
	options.type = 'single';
	options.helpMessage = 'editing.tools.addpart';
	options.help = 'editing.steps.help.select_element';
	const selectelementssteps = new PickFeatureStep();
	selectelementssteps.getTask().setSteps({
	select: {
	description: 'editing.workflow.steps.select',
	directive: 't-plugin',
	done: false
	}
	});
	options.add = false;
	const addfeaturestep = new AddFeatureStep(options);
	addfeaturestep.getTask().setSteps({
	addfeature: {
	description: 'editing.workflow.steps.draw_part',
	directive: 't-plugin',
	done: false
	}
	});
	addfeaturestep.on('run', ({inputs, context}) => {
	const layer = inputs.layer;
	const snapTool = {
	type: 'snap',
	options: {
	layerId: layer.getId(),
	source: layer.getEditingLayer().getSource(),
	active: true
	}
	};
	this.emit('settoolsoftool', [snapTool]);
	});
	addfeaturestep.on('run', () => {
	this.emit('active', ['snap']);
	});
	addfeaturestep.on('stop', () => {
	this.emit('deactive', ['snap']);
	});
	const addparttogeometriesstep = new AddPartToMultigeometriesStep(options);
	options.steps = [selectelementssteps, new ChooseFeatureStep(), addfeaturestep, addparttogeometriesstep];
	this.registerEscKeyEvent();
	base(this, options);
	}
	inherit(AddPartToMultigeometriesWorflow, EditingWorkflow);
	module.exports = AddPartToMultigeometriesWorflow;

g3w-client-plugin-editing/workflows/steps/addparttomultigeometriesstep.js

Lines 1 to 12 in c7855f3

	const {base, inherit} = g3wsdk.core.utils;
	const EditingStep = require('./editingstep');
	const AddPartToMuligeometriesTask = require('./tasks/addparttomultigeometriestask');
	const AddPartToMuligeometriesStep = function(options={}) {
	options.task = new AddPartToMuligeometriesTask(options);
	base(this, options)
	};
	inherit(AddPartToMuligeometriesStep, EditingStep);
	module.exports = AddPartToMuligeometriesStep;

g3w-client-plugin-editing/workflows/steps/tasks/addparttomultigeometriestask.js

Lines 1 to 44 in c7855f3

	const { base, inherit } = g3wsdk.core.utils;
	const EditingTask = require('./editingtask');
	function AddPartToMuligeometriesTask(options={}) {
	base(this, options);
	}
	inherit(AddPartToMuligeometriesTask, EditingTask);
	const proto = AddPartToMuligeometriesTask.prototype;
	proto.run = function(inputs, context) {
	const d = $.Deferred();
	const { layer, features } = inputs;
	const layerId = layer.getId();
	const session = context.session;
	const feature = features[0];
	const featureGeometry = feature.getGeometry();
	const originalFeature = feature.clone();
	featureGeometry.setCoordinates([...featureGeometry.getCoordinates(), ...features[1].getGeometry().getCoordinates()]);
	/**
	* evaluated geometry expression
	*/
	this.evaluateExpressionFields({
	inputs,
	context,
	feature
	}).finally(()=>{
	session.pushUpdate(layerId, feature, originalFeature);
	inputs.features = [feature];
	d.resolve(inputs);
	});
	/**
	* end of evaluated
	*/
	return d.promise();
	};
	proto.stop = function() {
	};
	module.exports = AddPartToMuligeometriesTask;

In this folder the base classes that are provided by the core g3w-client repository: g3w-client/src/app/core/workflow

👋 Raruto

[FITCODE1]

Hi Raruto, Thanks for details. I will contact your sales department. Regards, Alin From: Raruto ***@***.***> Date: Friday, 12 January 2024 at 11:23 To: g3w-suite/g3w-client-plugin-editing ***@***.***> Cc: FITCODE1 ***@***.***>, Mention ***@***.***> Subject: Re: [g3w-suite/g3w-client-plugin-editing] AddPart - first geometry (Issue #86) Hi @FITCODE1<https://github.com/FITCODE1>, 1. is is possible to develop this feature? 2. when it could be available? Next stable G3W-SUITE release is expected to happen in 6 months, so June 2024 (the next one at the end of 2024). Usually, sponsored features are more likely to be implemented sooner, in this case contact ***@***.******@***.***> to get in touch with the sales department. Otherwise, just propose your own PR to speed things up. Below almost all the code that handles the "Add part to multipart" button (you can use that as a starting point to create a your own button): https://github.com/g3w-suite/g3w-client-plugin-editing/blob/c7855f31a22b6431591b6224be59194b9d511815/toolboxes/toolsfactory.js#L147-L160 https://github.com/g3w-suite/g3w-client-plugin-editing/blob/c7855f31a22b6431591b6224be59194b9d511815/toolboxes/toolsfactory.js#L301-L314 https://github.com/g3w-suite/g3w-client-plugin-editing/blob/c7855f31a22b6431591b6224be59194b9d511815/workflows/addparttomultigeometriesworkflow.js#L1-L55 https://github.com/g3w-suite/g3w-client-plugin-editing/blob/c7855f31a22b6431591b6224be59194b9d511815/workflows/steps/addparttomultigeometriesstep.js#L1-L12 https://github.com/g3w-suite/g3w-client-plugin-editing/blob/c7855f31a22b6431591b6224be59194b9d511815/workflows/steps/tasks/addparttomultigeometriestask.js#L1-L44 g3w-client/src/app/core/workflow<https://github.com/g3w-suite/g3w-client/blob/8ab3917b5a5836683149e8fe67ec745ee2f3ab06/src/app/core/workflow> 👋 Raruto — Reply to this email directly, view it on GitHub<#86 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AINJ5KFM2XCVKNQ63S2A3G3YOD6I3AVCNFSM6AAAAABBWD4MNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBYG4ZDSMJQGA>. You are receiving this because you were mentioned.Message ID: ***@***.***>