-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set a default fallback image as Group header logo image on save (ref: CLIENT_G3WSUITE_LOGO
)
#509
Conversation
…c workflow for header_logo_img.
@volterra79 by chance, do you encounter any particular issues with this edit? I'm not really sure if it's related, but after I switched to this branch I got all the admin CSS and JS files messed up (ie. 4xx error) |
@Raruto i need to try. I let you know |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test perfomed: "deleting a previously uploaded image"
The image field is still mandatory if you try to delete a previously uploaded image. The problem here lies in the fact that the form interface does not show the field as mandatory (e.g. with an asterisk) before saving (or it's just an oversight and the field must always be optional).
@Raruto ok we left field mandatory, but we set by default a logo image. |
@wlorenzetti Good enough, I would also consider this other change: BEFORE:
|
CLIENT_G3WSUITE_LOGO
)
CLIENT_G3WSUITE_LOGO
)CLIENT_G3WSUITE_LOGO
)
Closes: #498