Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a default fallback image as Group header logo image on save (ref: CLIENT_G3WSUITE_LOGO) #509

Merged
merged 6 commits into from
Apr 12, 2023

Conversation

wlorenzetti
Copy link
Member

Closes: #498

@wlorenzetti wlorenzetti added the feature New feature or request label Mar 29, 2023
@wlorenzetti wlorenzetti added this to the v3.6 milestone Mar 29, 2023
@wlorenzetti wlorenzetti self-assigned this Mar 29, 2023
@wlorenzetti wlorenzetti requested a review from Raruto March 29, 2023 08:54
@Raruto Raruto added ux Changes to a current behavior to improve user experience and removed feature New feature or request labels Mar 30, 2023
@Raruto
Copy link
Contributor

Raruto commented Mar 30, 2023

@volterra79 by chance, do you encounter any particular issues with this edit?

I'm not really sure if it's related, but after I switched to this branch I got all the admin CSS and JS files messed up (ie. 4xx error)

@volterra79
Copy link
Member

@volterra79 by chance, do you encounter any particular issues with this edit?

I'm not really sure if it's related, but after I switched to this branch I got all the admin CSS and JS files messed up (ie. 4xx error)

@Raruto i need to try. I let you know

Copy link
Contributor

@Raruto Raruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test perfomed: "deleting a previously uploaded image"

The image field is still mandatory if you try to delete a previously uploaded image. The problem here lies in the fact that the form interface does not show the field as mandatory (e.g. with an asterisk) before saving (or it's just an oversight and the field must always be optional).

image

image

@wlorenzetti
Copy link
Member Author

@Raruto ok we left field mandatory, but we set by default a logo image.

@Raruto
Copy link
Contributor

Raruto commented Apr 5, 2023

@wlorenzetti Good enough, I would also consider this other change:

BEFORE: background-repeat: repeat;

image

AFTER: background-repeat: no-repeat;

image

@Raruto Raruto changed the title Remove 'required' condition for Group header logo image. Set a default fallback image for Group header logo image on save (ref: CLIENT_G3WSUITE_LOGO) Apr 12, 2023
@Raruto Raruto changed the title Set a default fallback image for Group header logo image on save (ref: CLIENT_G3WSUITE_LOGO) Set a default fallback image as Group header logo image on save (ref: CLIENT_G3WSUITE_LOGO) Apr 12, 2023
@wlorenzetti wlorenzetti merged commit 8f7de58 into dev Apr 12, 2023
@wlorenzetti wlorenzetti deleted the Fix_issue_498 branch April 12, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux Changes to a current behavior to improve user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional project logo/picture
3 participants