Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Makefile and desktop file to support distro packaging #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yarda
Copy link

@yarda yarda commented Jul 10, 2021

Signed-off-by: Jaroslav Škarvada [email protected]

Makefile Outdated
@@ -6,6 +6,10 @@ UNAME_S := $(shell uname -s)
GIT_DATE := $(firstword $(shell git --no-pager show --date=short --format="%ai" --name-only))
GIT_VERSION := $(shell git describe --abbrev=0 --tags)

PREFIX=/usr/local
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow override of PREFIX, BINDIR, DATADIR and also support installation to arbitrary DESTDIR which is required by distro packaging.

Makefile Outdated
@@ -273,7 +277,7 @@ actions.o


$(PROGRAM): $(OBJS) $(SOAPYSDR_OBJS) $(CWDAEMON_OBJS) $(MIDI_OBJS)
$(LINK) -o $(PROGRAM) $(OBJS) $(SOAPYSDR_OBJS) $(CWDAEMON_OBJS) $(MIDI_OBJS) $(LIBS)
$(LINK) -o $(PROGRAM) $(LDFLAGS) $(OBJS) $(SOAPYSDR_OBJS) $(CWDAEMON_OBJS) $(MIDI_OBJS) $(LIBS)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support distro LDFLAGS.

Makefile Outdated
@@ -288,12 +292,12 @@ clean:
-rm -f $(PROGRAM)

install: $(PROGRAM)
cp $(PROGRAM) /usr/local/bin
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix parallel installation by processing commands sequentially.
Use mkdir -p for creation of all directories.
Use cp -a to preserve build timestamps (probably better to use install -p.
Install hspdr_icon.png to the proper system wide place.

@@ -1,9 +1,7 @@
[Desktop Entry]
Version=0.1
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is version of the desktop file specification, not the program version. The 0.1 is invalid desktop file specificaiton version. This entry is optional, thus drop it.

Type=Application
Terminal=false
Name[eb_GB]=linHPSDR
Exec=linhpsdr
Icon=/usr/share/linhpsdr/hpsdr_small.png
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use system wide icon.

@yarda
Copy link
Author

yarda commented Jul 10, 2021

FYI: we are trying to get this package to Fedora:
https://bugzilla.redhat.com/show_bug.cgi?id=1981048

@andreasdotorg
Copy link
Contributor

Looks good to me. Merge conflicts though, will have a look at at that.

@yarda
Copy link
Author

yarda commented Apr 14, 2022

Rebased.

@andreasdotorg
Copy link
Contributor

Merged to andreasdotorg/linhpsdr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants