-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.length() functions in types are confusing with length(x) functions. #245
Comments
I noticed that some function implementations are using the length() method (such as here). Won't this cause compile errors if GLM_FORCE_SIZE_FUNC is used, making length() undefined? Apologies for the noise if you're already aware, and thanks again for change. |
Damn, stupid overlook. |
… constructor to quaternion. Fixed lack of conscistency or quaternion constructors with other types. Various uninitilized constructor optimizations
This should be fixed. Thanks for reporting, |
Awesome, nice solution. |
Sorry to be the carrier of bad news always, but I found some other places that are still directly using length(), they look to be mainly in the debug asserts, which are using it like
Other thing is, is there any way to make use of some of the tests with this flag on? I see .length() is used in there, but then you possibly don't want to use |
It should be fixed now, until the next one (:p), and I have added a test. Thanks, |
… usage of vec3::length()
fyi you will have issues with vec.length() and length(vec) in C++17 when the uniform call syntax is implemented. |
Add GLM_FORCE_SIZE_FUNC to use size_t size() instead of length_t length().
The text was updated successfully, but these errors were encountered: