Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glm::orientation with GLM_FORCE_RADIANS bug #112

Closed
error256 opened this issue Sep 5, 2013 · 1 comment
Closed

glm::orientation with GLM_FORCE_RADIANS bug #112

error256 opened this issue Sep 5, 2013 · 1 comment
Assignees
@Groovounet
Labels
bug
Milestone
GLM 0.9.4

Comments

@error256
Copy link

error256 commented Sep 5, 2013

glm::orientation returns incorrect results when GLM_FORCE_RADIANS is defined.
The result of acos shouldn't be converted to degrees before passing it to rotate in this case.
@ghost ghost assigned Groovounet Sep 8, 2013
Groovounet pushed a commit that referenced this issue Sep 8, 2013
Fixed glm::orientation with GLM_FORCE_RADIANS defined #112
c9f623e
@Groovounet
Copy link
Member

This issue is now fixed in GLM 0.9.4 branch.

Thanks for contributing!
Christophe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Groovounet Groovounet

Labels
bug
Projects
None yet
Milestone
GLM 0.9.4
Development

No branches or pull requests
2 participants
@Groovounet @error256