Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto detect and use fvm #2390

Merged
merged 9 commits into from
Nov 5, 2024
Merged

Auto detect and use fvm #2390

merged 9 commits into from
Nov 5, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Nov 5, 2024

Changes

Close #2300

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy merged commit 648c239 into master Nov 5, 2024
@fzyzcjy fzyzcjy deleted the feat/12627 branch November 5, 2024 05:01
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.92%. Comparing base (8c0d157) to head (e632d27).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
frb_codegen/src/library/commands/fvm.rs 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2390      +/-   ##
==========================================
- Coverage   98.93%   98.92%   -0.02%     
==========================================
  Files         493      494       +1     
  Lines       20347    20365      +18     
==========================================
+ Hits        20131    20146      +15     
- Misses        216      219       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow flutter_rust_bridge_codegen to use fvm flutter
1 participant