-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typo #2349
Fixed typo #2349
Conversation
Hi! Thanks for opening this pull request! 😄 |
Hi thanks for fixing typos! However, I guess "another" is not very wrong, because I want to say it is one other library. Btw, if you are interested in fixing typos in doc to improve reading, feel free to do so! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2349 +/- ##
==========================================
- Coverage 98.92% 97.75% -1.18%
==========================================
Files 493 493
Lines 20347 20328 -19
==========================================
- Hits 20129 19872 -257
- Misses 218 456 +238 ☔ View full report in Codecov by Sentry. |
AI tells me that the old sentence do have a grammar mistake and the new one don't, because "another" can only be a determeter while "other" can be an adjective. And "Here is my other open-source library" do mean "这是我的另一个开源库". But it is so common for non-native English users to make this mistake.😂 I think this PR shall be merged. |
Thanks! |
Hi! Congrats on merging your first pull request! 🎉 |
(CI failure is unrelated; I will fix it separately) |
@all-contributors please add ernstvanderlinden for doc |
I've put up a pull request to add @ernstvanderlinden! 🎉 |
Changes
Please list issues fixed by this PR here, using format "Fixes #the-issue-number".
Checklist
./frb_internal precommit --mode slow
(orfast
) is run (it internal runs code generator, does auto formatting, etc)../website
folder) are updated.Remark for PR creator
Great project, thanks!
./frb_internal --help
shows utilities for development.