Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo #2349

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Fixed typo #2349

merged 2 commits into from
Nov 23, 2024

Conversation

ernstvanderlinden
Copy link
Contributor

Changes

Please list issues fixed by this PR here, using format "Fixes #the-issue-number".

Checklist

  • [ x] An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

Great project, thanks!

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

Copy link

welcome bot commented Oct 13, 2024

Hi! Thanks for opening this pull request! 😄

@fzyzcjy
Copy link
Owner

fzyzcjy commented Oct 13, 2024

Hi thanks for fixing typos! However, I guess "another" is not very wrong, because I want to say it is one other library. Btw, if you are interested in fixing typos in doc to improve reading, feel free to do so!

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (0dd3f79) to head (6ef2e43).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2349      +/-   ##
==========================================
- Coverage   98.92%   97.75%   -1.18%     
==========================================
  Files         493      493              
  Lines       20347    20328      -19     
==========================================
- Hits        20129    19872     -257     
- Misses        218      456     +238     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GasinAn
Copy link

GasinAn commented Nov 22, 2024

AI tells me that the old sentence do have a grammar mistake and the new one don't, because "another" can only be a determeter while "other" can be an adjective. And "Here is my other open-source library" do mean "这是我的另一个开源库". But it is so common for non-native English users to make this mistake.😂 I think this PR shall be merged.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Nov 23, 2024

Thanks!

@fzyzcjy fzyzcjy merged commit b5cc429 into fzyzcjy:master Nov 23, 2024
130 of 135 checks passed
Copy link

welcome bot commented Nov 23, 2024

Hi! Congrats on merging your first pull request! 🎉

@fzyzcjy
Copy link
Owner

fzyzcjy commented Nov 23, 2024

(CI failure is unrelated; I will fix it separately)

@fzyzcjy
Copy link
Owner

fzyzcjy commented Nov 23, 2024

@all-contributors please add ernstvanderlinden for doc

Copy link
Contributor

@fzyzcjy

I've put up a pull request to add @ernstvanderlinden! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants