fix Issue [#2178] and Issue [#2167] #2187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 4, 2024
fzyzcjy
approved these changes
Jul 4, 2024
frb_codegen/src/library/codegen/parser/mir/parser/function/real/mod.rs
Outdated
Show resolved
Hide resolved
frb_codegen/src/library/codegen/parser/mir/parser/function/real/mod.rs
Outdated
Show resolved
Hide resolved
|
Other things to do before merging
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fix Issue [#2178] and Issue [#2167].
Close #2167 , Close #2178 (use this format to let github understand it)
Checklist
./frb_internal precommit --mode slow(orfast) is run (it internal runs code generator, does auto formatting, etc)../websitefolder) are updated.Remark for PR creator
./frb_internal --helpshows utilities for development.I hope that this PR is OK. I did my best 😃