-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate methods of Default
trait ; Automatically rename function names to avoid keyword conflict ; Improve parsing trait impl in third party crates
#2150
Conversation
Default
trait ; Automatically rename function names to avoid keyword conflictDefault
trait ; Automatically rename function names to avoid keyword conflict ; Improve parsing trait impl in third party crates
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2150 +/- ##
==========================================
- Coverage 99.10% 99.10% -0.01%
==========================================
Files 486 486
Lines 19990 19987 -3
==========================================
- Hits 19812 19809 -3
Misses 178 178 ☔ View full report in Codecov by Sentry. |
@fzyzcjy Re: Automatically rename function names to avoid keyword conflict We had a method named Force renaming it as
Can we add an option to ignore this check or apply the macro as last step? |
and generate Dart bindings. * 2.1.0 has introduced a regression: fzyzcjy/flutter_rust_bridge#2150 (comment)
@erdemyerebasmaz Hi could you please create a separate issue, thus it is easier to check |
and generate Dart bindings. * 2.1.0 has introduced a regression: fzyzcjy/flutter_rust_bridge#2150 (comment)
Changes
Close #2136
Checklist
./frb_internal precommit --mode slow
(orfast
) is run (it internal runs code generator, does auto formatting, etc)../website
folder) are updated.Remark for PR creator
./frb_internal --help
shows utilities for development.