Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #[frb(type_64bit_int)] to pick preferred Dart big integer type #2065

Merged
merged 56 commits into from
Jun 12, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jun 11, 2024

Changes

Close #2035

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 96.51163% with 3 lines in your changes missing coverage. Please review.

Project coverage is 99.07%. Comparing base (918a23c) to head (be2d54f).

Files Patch % Lines
...st/spec_generator/codec/cst/decoder/ty/delegate.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2065      +/-   ##
==========================================
- Coverage   99.08%   99.07%   -0.01%     
==========================================
  Files         471      471              
  Lines       18615    18693      +78     
==========================================
+ Hits        18445    18521      +76     
- Misses        170      172       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy marked this pull request as ready for review June 12, 2024 02:21
@fzyzcjy fzyzcjy merged commit 54d09eb into master Jun 12, 2024
104 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After mapping usize to BigInt, the generated Dart code with #[frb(default = 10)] throw casting error.
1 participant