-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dashed library names #2034
Fix dashed library names #2034
Conversation
Hi! Thanks for opening this pull request! 😄 |
Good fix! After CI is green, i.e. fix the lint error -
I am ready to merge it :) |
Btw, for dashed library names, does the other parts of flutter_rust_bridge work? |
So far, I haven't encountered any other issues using a dashed crate name ¯_(ツ)_/¯ |
Then that's great! |
Hi! Congrats on merging your first pull request! 🎉 |
@all-contributors please add @vhdirk for code |
I've put up a pull request to add @vhdirk! 🎉 |
Changes
Rust library names can't have dashes, while the package name can. This fixes it.
Checklist
./frb_internal precommit --mode slow
(orfast
) is run (it internal runs code generator, does auto formatting, etc)../website
folder) are updated.Remark for PR creator
./frb_internal --help
shows utilities for development.