Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding things in third party crate (part 2) #2013

Merged
merged 14 commits into from
Jun 2, 2024
Merged

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jun 2, 2024

Changes

Please list issues fixed by this PR here, using format "Fixes #the-issue-number".

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

Copy link

codecov bot commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 98.32%. Comparing base (977a7e1) to head (be893ea).
Report is 3 commits behind head on master.

Current head be893ea differs from pull request most recent head d0c8536

Please upload reports for the commit d0c8536 to get more accurate results.

Files Patch % Lines
...r/hierarchical/third_party_override_transformer.rs 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2013      +/-   ##
==========================================
- Coverage   98.38%   98.32%   -0.06%     
==========================================
  Files         410      410              
  Lines       16792    16801       +9     
==========================================
  Hits        16520    16520              
- Misses        272      281       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit d67cada into master Jun 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant