Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inserting arbitrary Dart code; Support disabling default Hash/Eq generation #1860

Merged
merged 50 commits into from
Apr 8, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Apr 7, 2024

Changes

fix (partially) #1850

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy marked this pull request as ready for review April 7, 2024 10:38
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 98.86364% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.23%. Comparing base (4f9c6a2) to head (c789971).
Report is 40 commits behind head on master.

❗ Current head c789971 differs from pull request most recent head 27acac3. Consider uploading reports for the commit 27acac3 to get more accurate results

Files Patch % Lines
.../library/codegen/parser/type_parser/enumeration.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1860      +/-   ##
==========================================
- Coverage   99.26%   93.23%   -6.04%     
==========================================
  Files         366      366              
  Lines       15321    15230      -91     
==========================================
- Hits        15208    14199    -1009     
- Misses        113     1031     +918     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fzyzcjy and others added 16 commits April 8, 2024 09:45
@fzyzcjy fzyzcjy merged commit 5cda35a into master Apr 8, 2024
92 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant