Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated cargokit, fixes: #1494, Not possible to build if rust toolchain for esp32 is installed #1498

Merged
merged 2 commits into from
Dec 31, 2023

Conversation

mattiasgronlund
Copy link
Contributor

Changes

Fixes: #1494

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Copy link

welcome bot commented Dec 26, 2023

Hi! Thanks for opening this pull request! 😄

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2a84fa) 99.20% compared to head (3b97a55) 97.89%.
Report is 8 commits behind head on master.

❗ Current head 3b97a55 differs from pull request most recent head 9d01527. Consider uploading reports for the commit 9d01527 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1498      +/-   ##
==========================================
- Coverage   99.20%   97.89%   -1.31%     
==========================================
  Files         341      341              
  Lines       13183    13115      -68     
==========================================
- Hits        13078    12839     -239     
- Misses        105      276     +171     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Dec 27, 2023

Good job! Maybe try ./frb_internal precommit --mode slow to update some code automatically and fix the CI, and I am ready to merge after CI is green :)

@fzyzcjy
Copy link
Owner

fzyzcjy commented Dec 31, 2023

I will merge this and run the commands since they are automatic.

@fzyzcjy fzyzcjy merged commit 09de299 into fzyzcjy:master Dec 31, 2023
64 of 72 checks passed
Copy link

welcome bot commented Dec 31, 2023

Hi! Congrats on merging your first pull request! 🎉

@fzyzcjy
Copy link
Owner

fzyzcjy commented Dec 31, 2023

@all-contributors please add @mattiasgronlund for code

Copy link
Contributor

@fzyzcjy

I've put up a pull request to add @mattiasgronlund! 🎉

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Not possible to build if rust toolchain for esp32 is installed
2 participants