Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1454 by setting the msrv #1463
Fixes #1454 by setting the msrv #1463
Changes from 10 commits
b003fef
8097db5
431a8a0
5822266
f63eda9
5584ca1
f1d760a
3e9918d
1b11265
72f8ad0
a880abe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be great if we can lower the MSRV by fixing some trivial compile errors ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm - I personally don't mind, as I like to use the latest version.
But I suggest opening another issue for that. In #1454 you can get an impression of what kind of changes would have to be made (that was with rust 1.71., the compiler complained about
pup (crate)
mostly).I assume that would require a redesign of the modularization.
IMHO: Not worth it, would not do that unless somebody complains.
I got to the MSRV of 1.74.0 by using
cargo msrv
, which performs a bisect search. So it won't compile to anything lower without changes to the code.I would leave it as it, and only of somebody raises an issue needing a lower version work on specifically supporting from that version on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Then let's keep this PR simple and atomic.