Merge pull request #1463 from patmuk/fixes-#1454-by-setting-the-MSRV

Fixes #1454 by setting the msrv

.github/workflows/ci.yaml

@@ -113,6 +113,30 @@ jobs:
       - run: ./frb_internal lint-dart
 
   # ----------------------------------- codegen -----------------------------------
+  # instead of running this explicit test for frb_codegen and frb_rust only, we run the test for
+  # all rust packages in the job "test_rust". While this would not be needed for these other packages,
+  # we avoid a ci dependency to cargo-msrv.
+  # However, the code is left commented here in case this decission changes.
+  # msrv:
+  #   name: 'Test :: FRB Codegen :: MSRV'    
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #   - uses: actions/checkout@v2
+
+  #   - name: Install Rust
+  #     uses: actions-rs/toolchain@v1
+  #     with:
+  #       toolchain: stable
+
+  #   - name: Verify MSRV for frb_codegen
+  #     run: |
+  #       cargo install cargo-msrv
+  #       cargo msrv --path frb_codegen verify
+
+  #   - name: Verify MSRV for frb_rust
+  #     run: |
+  #       cargo install cargo-msrv
+  #       cargo msrv --path frb_rust verify
 
   generate_run_frb_codegen_command_generate:
     name: 'Generate :: FRB Codegen :: Command Generate'
@@ -155,7 +179,7 @@ jobs:
           flutter-version: ${{ env.FRB_MAIN_FLUTTER_VERSION }}
           architecture: x64
       - uses: taiki-e/install-action@cargo-llvm-cov
-
+      
       # execute
       - run: ./frb_internal generate-run-frb-codegen-command-generate --set-exit-if-changed --package ${{ matrix.package }} --coverage
 
@@ -379,7 +403,11 @@ jobs:
             version: nightly
           - image: ubuntu-latest
             version: nightly-2023-12-16
-          # TODO(@fzyzcjy, @gutenfries): add MSRV here, as well as other locked versions as needed
+          # tests the MSRV
+          # run on all rust packages, though only needed for frb_rust and frb_codegen
+          - image: ubuntu-latest
+          # update this, if a later MSRV is needed
+            version: 1.74.0
 
     steps:
       # setup
@@ -407,8 +435,8 @@ jobs:
       - uses: actions/upload-artifact@v4
         with:
           name: ${{ github.job }}--${{ matrix.info.image }}--${{ matrix.info.version }}--coverage
-          path: target/coverage
-
+          path: target/coverage  
+    
   test_dart_native:
     name: 'Test :: Dart :: Native'
     runs-on: ${{ matrix.image }}

frb_codegen/Cargo.toml

@@ -2,6 +2,7 @@
 categories.workspace = true
 description.workspace = true
 edition.workspace = true
+rust-version = "1.74.0"
 keywords.workspace = true
 license.workspace = true
 name = "flutter_rust_bridge_codegen"

frb_rust/Cargo.toml

@@ -1,6 +1,7 @@
 [package]
 name = "flutter_rust_bridge"
 edition.workspace = true
+rust-version = "1.70.0"
 version.workspace = true
 description.workspace = true
 license.workspace = true