netsuite error parser support for JE and Bills #118

NileshPant1999 · 2023-06-01T09:21:35Z

No description provided.

…to parser-netsuite-error-bugdix

github-actions · 2023-06-01T09:27:31Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	0	100%
connection.py	70	0	100%
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	0	100%
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	9	90%	26–33, 43–44, 56, 85, 103, 121–122
classifications.py	6	0	100%
currencies.py	10	0	100%
custom_record_types.py	11	0	100%
custom_records.py	17	0	100%
customers.py	21	0	100%
departments.py	6	0	100%
employees.py	34	0	100%
expense_categories.py	6	0	100%
expense_reports.py	58	2	97%	38, 46
files.py	23	0	100%
folders.py	17	0	100%
items.py	12	0	100%
journal_entries.py	41	0	100%
locations.py	6	0	100%
price_level.py	6	0	100%
projects.py	6	0	100%
subsidiaries.py	6	0	100%
tax_groups.py	6	0	100%
tax_items.py	6	0	100%
vendor_bills.py	68	0	100%
vendor_payments.py	46	1	98%	41
vendors.py	21	0	100%
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	2	0	100%
helpers.py	14	1	93%	21
parser.py	27	6	78%	17–18, 21–22, 25–26
netsuitesdk/internal
__init__.py	0	0	100%
client.py	312	77	75%	75, 114–115, 133–134, 147, 154–155, 162–163, 166–188, 210, 217–225, 245–248, 280, 285–291, 323, 326–329, 353, 355, 358–359, 380, 415–416, 421, 467–471, 485–486, 546–555, 604, 608, 620–621
constants.py	4	0	100%
exceptions.py	16	3	81%	24–26
netsuite_types.py	2	0	100%
utils.py	40	4	90%	34, 52, 63, 65
TOTAL	1027	103	90%

Tests	Skipped	Failures	Errors	Time
103	11 💤	0 ❌	0 🔥	5m 33s ⏱️

Shwetabhk · 2023-06-01T11:35:50Z

setup.py

@@ -5,7 +5,7 @@

 setuptools.setup(
    name='netsuitesdk',
-    version='2.18.1',
+    version='2.18.2',


please make it 2.19.0
minor version is only for bugfixes

Shwetabhk · 2023-06-01T11:37:47Z

netsuitesdk/errors/errors.py

@@ -1,18 +1,33 @@

 error_reference = {
- "expense_report": 
-    {
+    "expense_report": {
        'category_reference_error': {'regex': r"An error occured in a upsert request: Invalid category reference key \d+ for entity \d+", 'keys': ['expense_category', 'employee']},


Suggested change

'category_reference_error': {'regex': r"An error occured in a upsert request: Invalid category reference key \d+ for entity \d+", 'keys': ['expense_category', 'employee']},

'category_reference_error': {

'regex': r"An error occured in a upsert request: Invalid category reference key \d+ for entity \d+",

'keys': ['expense_category', 'employee']

},

@NileshPant1999 can we format all errors like this, makes them more readable

github-actions · 2023-06-01T14:22:38Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	0	100%
connection.py	70	0	100%
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	0	100%
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	9	90%	26–33, 43–44, 56, 85, 103, 121–122
classifications.py	6	0	100%
currencies.py	10	0	100%
custom_record_types.py	11	0	100%
custom_records.py	17	0	100%
customers.py	21	0	100%
departments.py	6	0	100%
employees.py	34	0	100%
expense_categories.py	6	0	100%
expense_reports.py	58	2	97%	38, 46
files.py	23	0	100%
folders.py	17	0	100%
items.py	12	0	100%
journal_entries.py	41	0	100%
locations.py	6	0	100%
price_level.py	6	0	100%
projects.py	6	0	100%
subsidiaries.py	6	0	100%
tax_groups.py	6	0	100%
tax_items.py	6	0	100%
vendor_bills.py	68	0	100%
vendor_payments.py	46	1	98%	41
vendors.py	21	0	100%
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	2	0	100%
helpers.py	14	1	93%	21
parser.py	28	4	86%	17–18, 25–26
netsuitesdk/internal
__init__.py	0	0	100%
client.py	312	77	75%	75, 114–115, 133–134, 147, 154–155, 162–163, 166–188, 210, 217–225, 245–248, 280, 285–291, 323, 326–329, 353, 355, 358–359, 380, 415–416, 421, 467–471, 485–486, 546–555, 604, 608, 620–621
constants.py	4	0	100%
exceptions.py	16	3	81%	24–26
netsuite_types.py	2	0	100%
utils.py	40	4	90%	34, 52, 63, 65
TOTAL	1028	101	90%

Tests	Skipped	Failures	Errors	Time
105	11 💤	0 ❌	0 🔥	3m 38s ⏱️

github-actions · 2023-06-01T17:52:09Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	0	100%
connection.py	70	0	100%
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	0	100%
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	9	90%	26–33, 43–44, 56, 85, 103, 121–122
classifications.py	6	0	100%
currencies.py	10	0	100%
custom_record_types.py	11	0	100%
custom_records.py	17	0	100%
customers.py	21	0	100%
departments.py	6	0	100%
employees.py	34	0	100%
expense_categories.py	6	0	100%
expense_reports.py	58	2	97%	38, 46
files.py	23	0	100%
folders.py	17	0	100%
items.py	12	0	100%
journal_entries.py	41	0	100%
locations.py	6	0	100%
price_level.py	6	0	100%
projects.py	6	0	100%
subsidiaries.py	6	0	100%
tax_groups.py	6	0	100%
tax_items.py	6	0	100%
vendor_bills.py	68	0	100%
vendor_payments.py	46	1	98%	41
vendors.py	21	0	100%
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	2	0	100%
helpers.py	14	1	93%	21
parser.py	28	4	86%	17–18, 25–26
netsuitesdk/internal
__init__.py	0	0	100%
client.py	312	77	75%	75, 114–115, 133–134, 147, 154–155, 162–163, 166–188, 210, 217–225, 245–248, 280, 285–291, 323, 326–329, 353, 355, 358–359, 380, 415–416, 421, 467–471, 485–486, 546–555, 604, 608, 620–621
constants.py	4	0	100%
exceptions.py	16	3	81%	24–26
netsuite_types.py	2	0	100%
utils.py	40	4	90%	34, 52, 63, 65
TOTAL	1028	101	90%

Tests	Skipped	Failures	Errors	Time
102	11 💤	0 ❌	0 🔥	3m 58s ⏱️

NileshPant1999 added 6 commits May 31, 2023 02:26

bug fix: minor fix for string replacement

59e5c0b

fux

e63cd02

test

4621966

testf ix

bb9975b

Merge branch 'master' of https://github.com/fylein/netsuite-sdk-py in…

b3d534d

…to parser-netsuite-error-bugdix

added support for parser for JE and Bills

1349c94

NileshPant1999 temporarily deployed to CI Environment June 1, 2023 09:21 — with GitHub Actions Inactive

NileshPant1999 requested a review from Shwetabhk June 1, 2023 11:05

Shwetabhk reviewed Jun 1, 2023

View reviewed changes

add test and comments resolved

7cd6f91

NileshPant1999 temporarily deployed to CI Environment June 1, 2023 14:18 — with GitHub Actions Inactive

fix test

590148c

NileshPant1999 temporarily deployed to CI Environment June 1, 2023 17:47 — with GitHub Actions Inactive

Shwetabhk approved these changes Jun 2, 2023

View reviewed changes

NileshPant1999 merged commit b7228e6 into master Jun 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

netsuite error parser support for JE and Bills #118

netsuite error parser support for JE and Bills #118

NileshPant1999 commented Jun 1, 2023

github-actions bot commented Jun 1, 2023

Shwetabhk Jun 1, 2023

Shwetabhk Jun 1, 2023

github-actions bot commented Jun 1, 2023

github-actions bot commented Jun 1, 2023

netsuite error parser support for JE and Bills #118

netsuite error parser support for JE and Bills #118

Conversation

NileshPant1999 commented Jun 1, 2023

github-actions bot commented Jun 1, 2023

Shwetabhk Jun 1, 2023

Choose a reason for hiding this comment

Shwetabhk Jun 1, 2023

Choose a reason for hiding this comment

github-actions bot commented Jun 1, 2023

github-actions bot commented Jun 1, 2023