feature: support of error parser for expense report export #113

NileshPant1999 · 2023-05-16T10:07:00Z

No description provided.

github-actions · 2023-05-16T10:07:29Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	3	25%	2–14
connection.py	68	52	24%	17–79
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	1	83%	9
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	60	33%	15–16, 26–33, 36–40, 43–44, 50, 53, 56, 60, 63–64, 71, 78, 82–98, 102–114, 117–118, 121–122, 125–126, 129–131, 134–135, 138–140, 143–145
classifications.py	6	1	83%	8
currencies.py	10	3	70%	8, 11, 17
custom_record_types.py	11	11	0%	1–21
custom_records.py	17	17	0%	1–73
customers.py	21	21	0%	1–170
departments.py	6	1	83%	8
employees.py	34	27	21%	11, 14–52
expense_categories.py	6	6	0%	1–9
expense_reports.py	71	65	8%	10–116
files.py	23	23	0%	1–34
folders.py	17	17	0%	1–25
journal_entries.py	41	29	29%	29–34, 37–43, 46–81
locations.py	6	1	83%	8
price_level.py	6	6	0%	1–8
projects.py	6	6	0%	1–8
subsidiaries.py	6	1	83%	9
tax_groups.py	6	6	0%	1–9
tax_items.py	6	6	0%	1–9
vendor_bills.py	55	45	18%	18, 21–27, 30–96
vendor_payments.py	46	46	0%	1–73
vendors.py	21	12	43%	96, 99–116
netsuitesdk/internal
__init__.py	0	0	100%
client.py	305	252	17%	56–88, 92, 99–115, 118–134, 140, 143, 146–151, 154–159, 162–184, 202–224, 227–251, 268–272, 276, 279–287, 290–299, 313–328, 338–354, 370–387, 402–413, 416–422, 425–433, 452–468, 471–483, 504–515, 534–545, 592–611
constants.py	4	0	100%
error_parser.py	26	22	15%	4–6, 11–12, 16–37
exceptions.py	16	5	69%	20–21, 24–26
netsuite_types.py	2	0	100%
utils.py	40	23	42%	18–26, 30, 34, 38, 42, 46, 50–52, 56, 62–66
TOTAL	989	768	22%

Tests	Skipped	Failures	Errors	Time
1	0 💤	0 ❌	1 🔥	0.937s ⏱️

github-actions · 2023-05-16T10:14:35Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	0	100%
connection.py	68	0	100%
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	0	100%
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	9	90%	26–33, 43–44, 56, 85, 103, 121–122
classifications.py	6	0	100%
currencies.py	10	0	100%
custom_record_types.py	11	0	100%
custom_records.py	17	0	100%
customers.py	21	0	100%
departments.py	6	0	100%
employees.py	34	0	100%
expense_categories.py	6	0	100%
expense_reports.py	88	29	67%	39, 47, 104–134
files.py	23	0	100%
folders.py	17	0	100%
journal_entries.py	41	0	100%
locations.py	6	0	100%
price_level.py	6	0	100%
projects.py	6	0	100%
subsidiaries.py	6	0	100%
tax_groups.py	6	0	100%
tax_items.py	6	0	100%
vendor_bills.py	55	1	98%	89
vendor_payments.py	46	1	98%	41
vendors.py	21	0	100%
netsuitesdk/internal
__init__.py	0	0	100%
client.py	305	79	74%	71, 110–111, 129–130, 143, 150–151, 158–159, 162–184, 206, 213–221, 241–244, 276, 281–287, 318, 321–324, 348, 350, 353–354, 376, 412–413, 418, 464–468, 482–483, 514–515, 536–545, 594, 598, 610–611
constants.py	4	0	100%
error_parser.py	26	22	15%	4–6, 11–12, 16–37
exceptions.py	16	3	81%	24–26
netsuite_types.py	2	0	100%
utils.py	40	4	90%	34, 52, 63, 65
TOTAL	1006	148	85%

Tests	Skipped	Failures	Errors	Time
92	11 💤	0 ❌	0 🔥	4m 16s ⏱️

github-actions · 2023-05-24T15:25:21Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	0	100%
connection.py	70	0	100%
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	0	100%
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	9	90%	26–33, 43–44, 56, 85, 103, 121–122
classifications.py	6	0	100%
currencies.py	10	0	100%
custom_record_types.py	11	0	100%
custom_records.py	17	0	100%
customers.py	21	0	100%
departments.py	6	0	100%
employees.py	34	0	100%
expense_categories.py	6	0	100%
expense_reports.py	65	6	91%	39, 47, 104–107
files.py	23	0	100%
folders.py	17	0	100%
items.py	12	0	100%
journal_entries.py	41	0	100%
locations.py	6	0	100%
price_level.py	6	0	100%
projects.py	6	0	100%
subsidiaries.py	6	0	100%
tax_groups.py	6	0	100%
tax_items.py	6	0	100%
vendor_bills.py	55	1	98%	89
vendor_payments.py	46	1	98%	41
vendors.py	21	0	100%
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	1	0	100%
helpers.py	8	5	38%	4–6, 11–12
parser.py	38	33	13%	9–25, 30–53
netsuitesdk/internal
__init__.py	0	0	100%
client.py	305	79	74%	71, 110–111, 129–130, 143, 150–151, 158–159, 162–184, 206, 213–221, 241–244, 276, 281–287, 318, 321–324, 348, 350, 353–354, 376, 412–413, 418, 464–468, 482–483, 514–515, 536–545, 594, 598, 610–611
constants.py	4	0	100%
exceptions.py	16	3	81%	24–26
netsuite_types.py	2	0	100%
utils.py	40	4	90%	34, 52, 63, 65
TOTAL	1018	141	86%

Tests	Skipped	Failures	Errors	Time
93	11 💤	0 ❌	0 🔥	4m 10s ⏱️

github-actions · 2023-05-24T15:49:16Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	0	100%
connection.py	70	0	100%
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	0	100%
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	9	90%	26–33, 43–44, 56, 85, 103, 121–122
classifications.py	6	0	100%
currencies.py	10	0	100%
custom_record_types.py	11	0	100%
custom_records.py	17	0	100%
customers.py	21	0	100%
departments.py	6	0	100%
employees.py	34	0	100%
expense_categories.py	6	0	100%
expense_reports.py	66	6	91%	40, 48, 105–108
files.py	23	0	100%
folders.py	17	0	100%
items.py	12	0	100%
journal_entries.py	41	0	100%
locations.py	6	0	100%
price_level.py	6	0	100%
projects.py	6	0	100%
subsidiaries.py	6	0	100%
tax_groups.py	6	0	100%
tax_items.py	6	0	100%
vendor_bills.py	55	1	98%	89
vendor_payments.py	46	1	98%	41
vendors.py	21	0	100%
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	1	0	100%
helpers.py	23	18	22%	6–8, 12–13, 18–34
parser.py	22	20	9%	6–29
netsuitesdk/internal
__init__.py	0	0	100%
client.py	305	79	74%	71, 110–111, 129–130, 143, 150–151, 158–159, 162–184, 206, 213–221, 241–244, 276, 281–287, 318, 321–324, 348, 350, 353–354, 376, 412–413, 418, 464–468, 482–483, 514–515, 536–545, 594, 598, 610–611
constants.py	4	0	100%
exceptions.py	16	3	81%	24–26
netsuite_types.py	2	0	100%
utils.py	40	4	90%	34, 52, 63, 65
TOTAL	1018	141	86%

Tests	Skipped	Failures	Errors	Time
93	11 💤	0 ❌	0 🔥	4m 4s ⏱️

NileshPant1999 · 2023-05-25T06:16:27Z

netsuitesdk/errors/parser.py

+from .helpers import decode_project_or_customer_name, replace_numbers
+
+
+def expense_report_error_parser(error_dict, ns_client, message):


once we move ahead with other module and see the pattern
will make this function generic too.

github-actions · 2023-05-25T06:47:14Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	0	100%
connection.py	70	0	100%
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	0	100%
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	9	90%	26–33, 43–44, 56, 85, 103, 121–122
classifications.py	6	0	100%
currencies.py	10	0	100%
custom_record_types.py	11	0	100%
custom_records.py	17	0	100%
customers.py	21	0	100%
departments.py	6	0	100%
employees.py	34	0	100%
expense_categories.py	6	0	100%
expense_reports.py	66	6	91%	40, 48, 105–108
files.py	23	0	100%
folders.py	17	0	100%
items.py	12	0	100%
journal_entries.py	41	0	100%
locations.py	6	0	100%
price_level.py	6	0	100%
projects.py	6	0	100%
subsidiaries.py	6	0	100%
tax_groups.py	6	0	100%
tax_items.py	6	0	100%
vendor_bills.py	55	1	98%	89
vendor_payments.py	46	1	98%	41
vendors.py	21	0	100%
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	1	0	100%
helpers.py	29	24	17%	6–8, 12–13, 18–42
parser.py	30	28	7%	6–39
netsuitesdk/internal
__init__.py	0	0	100%
client.py	305	79	74%	71, 110–111, 129–130, 143, 150–151, 158–159, 162–184, 206, 213–221, 241–244, 276, 281–287, 318, 321–324, 348, 350, 353–354, 376, 412–413, 418, 464–468, 482–483, 514–515, 536–545, 594, 598, 610–611
constants.py	4	0	100%
exceptions.py	16	3	81%	24–26
netsuite_types.py	2	0	100%
utils.py	40	4	90%	34, 52, 63, 65
TOTAL	1032	155	85%

Tests	Skipped	Failures	Errors	Time
93	11 💤	0 ❌	0 🔥	4m 2s ⏱️

Shwetabhk · 2023-05-25T06:51:24Z

netsuitesdk/api/expense_reports.py

-        res = self.ns_client.upsert(er)
+        try:
+            res = self.ns_client.upsert(er)
+        except Exception as e:


I don't think we should use broad exception

github-actions · 2023-05-25T09:30:54Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	3	25%	2–14
connection.py	70	54	23%	17–81
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	1	83%	9
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	60	33%	15–16, 26–33, 36–40, 43–44, 50, 53, 56, 60, 63–64, 71, 78, 82–98, 102–114, 117–118, 121–122, 125–126, 129–131, 134–135, 138–140, 143–145
classifications.py	6	1	83%	8
currencies.py	10	3	70%	8, 11, 17
custom_record_types.py	11	11	0%	1–21
custom_records.py	17	17	0%	1–73
customers.py	21	21	0%	1–170
departments.py	6	1	83%	8
employees.py	34	27	21%	11, 14–52
expense_categories.py	6	6	0%	1–9
expense_reports.py	66	60	9%	9–110
files.py	23	23	0%	1–34
folders.py	17	17	0%	1–25
items.py	12	12	0%	1–24
journal_entries.py	41	29	29%	29–34, 37–43, 46–81
locations.py	6	1	83%	8
price_level.py	6	6	0%	1–8
projects.py	6	6	0%	1–8
subsidiaries.py	6	1	83%	9
tax_groups.py	6	6	0%	1–9
tax_items.py	6	6	0%	1–9
vendor_bills.py	55	45	18%	18, 21–27, 30–96
vendor_payments.py	46	46	0%	1–73
vendors.py	21	12	43%	96, 99–116
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	2	0	100%
helpers.py	27	25	7%	5–40
parser.py	19	18	5%	2–28
netsuitesdk/internal
__init__.py	0	0	100%
client.py	305	252	17%	56–88, 92, 99–115, 118–134, 140, 143, 146–151, 154–159, 162–184, 202–224, 227–251, 268–272, 276, 279–287, 290–299, 313–328, 338–354, 370–387, 402–413, 416–422, 425–433, 452–468, 471–483, 504–515, 534–545, 592–611
constants.py	4	0	100%
exceptions.py	16	5	69%	20–21, 24–26
netsuite_types.py	2	0	100%
utils.py	40	23	42%	18–26, 30, 34, 38, 42, 46, 50–52, 56, 62–66
TOTAL	1020	798	22%

Tests	Skipped	Failures	Errors	Time
1	0 💤	0 ❌	1 🔥	0.773s ⏱️

github-actions · 2023-05-25T09:33:22Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	3	25%	2–14
connection.py	70	54	23%	17–81
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	1	83%	9
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	60	33%	15–16, 26–33, 36–40, 43–44, 50, 53, 56, 60, 63–64, 71, 78, 82–98, 102–114, 117–118, 121–122, 125–126, 129–131, 134–135, 138–140, 143–145
classifications.py	6	1	83%	8
currencies.py	10	3	70%	8, 11, 17
custom_record_types.py	11	11	0%	1–21
custom_records.py	17	17	0%	1–73
customers.py	21	21	0%	1–170
departments.py	6	1	83%	8
employees.py	34	27	21%	11, 14–52
expense_categories.py	6	6	0%	1–9
expense_reports.py	66	60	9%	9–110
files.py	23	23	0%	1–34
folders.py	17	17	0%	1–25
items.py	12	12	0%	1–24
journal_entries.py	41	29	29%	29–34, 37–43, 46–81
locations.py	6	1	83%	8
price_level.py	6	6	0%	1–8
projects.py	6	6	0%	1–8
subsidiaries.py	6	1	83%	9
tax_groups.py	6	6	0%	1–9
tax_items.py	6	6	0%	1–9
vendor_bills.py	55	45	18%	18, 21–27, 30–96
vendor_payments.py	46	46	0%	1–73
vendors.py	21	12	43%	96, 99–116
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	2	0	100%
helpers.py	27	22	19%	6–7, 11, 16–40
parser.py	19	15	21%	6–18, 23–28
netsuitesdk/internal
__init__.py	0	0	100%
client.py	305	252	17%	56–88, 92, 99–115, 118–134, 140, 143, 146–151, 154–159, 162–184, 202–224, 227–251, 268–272, 276, 279–287, 290–299, 313–328, 338–354, 370–387, 402–413, 416–422, 425–433, 452–468, 471–483, 504–515, 534–545, 592–611
constants.py	4	0	100%
exceptions.py	16	5	69%	20–21, 24–26
netsuite_types.py	2	0	100%
utils.py	40	23	42%	18–26, 30, 34, 38, 42, 46, 50–52, 56, 62–66
TOTAL	1020	792	22%

Tests	Skipped	Failures	Errors	Time
1	0 💤	0 ❌	1 🔥	0.458s ⏱️

…to parse-netsuite-error

github-actions · 2023-05-25T09:39:13Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	0	100%
connection.py	70	0	100%
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	0	100%
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	9	90%	26–33, 43–44, 56, 85, 103, 121–122
classifications.py	6	0	100%
currencies.py	10	0	100%
custom_record_types.py	11	0	100%
custom_records.py	17	0	100%
customers.py	21	0	100%
departments.py	6	0	100%
employees.py	34	0	100%
expense_categories.py	6	0	100%
expense_reports.py	66	6	91%	40, 48, 105–108
files.py	23	0	100%
folders.py	17	0	100%
items.py	12	0	100%
journal_entries.py	41	0	100%
locations.py	6	0	100%
price_level.py	6	0	100%
projects.py	6	0	100%
subsidiaries.py	6	0	100%
tax_groups.py	6	0	100%
tax_items.py	6	0	100%
vendor_bills.py	55	1	98%	89
vendor_payments.py	46	1	98%	41
vendors.py	21	0	100%
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	2	0	100%
helpers.py	27	22	19%	6–7, 11, 16–40
parser.py	19	15	21%	6–18, 23–28
netsuitesdk/internal
__init__.py	0	0	100%
client.py	305	79	74%	71, 110–111, 129–130, 143, 150–151, 158–159, 162–184, 206, 213–221, 241–244, 276, 281–287, 318, 321–324, 348, 350, 353–354, 376, 412–413, 418, 464–468, 482–483, 514–515, 536–545, 594, 598, 610–611
constants.py	4	0	100%
exceptions.py	16	3	81%	24–26
netsuite_types.py	2	0	100%
utils.py	40	4	90%	34, 52, 63, 65
TOTAL	1020	140	86%

Tests	Skipped	Failures	Errors	Time
93	11 💤	0 ❌	0 🔥	3m 32s ⏱️

github-actions · 2023-05-26T08:04:30Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	0	100%
connection.py	70	0	100%
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	0	100%
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	9	90%	26–33, 43–44, 56, 85, 103, 121–122
classifications.py	6	0	100%
currencies.py	10	0	100%
custom_record_types.py	11	0	100%
custom_records.py	17	0	100%
customers.py	21	0	100%
departments.py	6	0	100%
employees.py	34	0	100%
expense_categories.py	6	0	100%
expense_reports.py	61	2	97%	40, 48
files.py	23	0	100%
folders.py	17	0	100%
items.py	12	0	100%
journal_entries.py	41	0	100%
locations.py	6	0	100%
price_level.py	6	0	100%
projects.py	6	0	100%
subsidiaries.py	6	0	100%
tax_groups.py	6	0	100%
tax_items.py	6	0	100%
vendor_bills.py	55	1	98%	89
vendor_payments.py	46	1	98%	41
vendors.py	21	0	100%
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	2	0	100%
helpers.py	13	1	92%	20
parser.py	24	11	54%	11–24
netsuitesdk/internal
__init__.py	0	0	100%
client.py	312	84	73%	75, 114–115, 133–134, 147, 154–155, 162–163, 166–188, 210, 217–225, 245–248, 280, 285–291, 323, 326–329, 353, 355, 358–359, 380, 415–416, 421, 467–471, 485–486, 517–525, 546–555, 604, 608, 620–621
constants.py	4	0	100%
exceptions.py	16	3	81%	24–26
netsuite_types.py	2	0	100%
utils.py	40	4	90%	34, 52, 63, 65
TOTAL	1013	116	89%

Tests	Skipped	Failures	Errors	Time
102	11 💤	1 ❌	0 🔥	3m 51s ⏱️

github-actions · 2023-05-26T09:25:44Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	0	100%
connection.py	70	0	100%
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	0	100%
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	9	90%	26–33, 43–44, 56, 85, 103, 121–122
classifications.py	6	0	100%
currencies.py	10	0	100%
custom_record_types.py	11	0	100%
custom_records.py	17	0	100%
customers.py	21	0	100%
departments.py	6	0	100%
employees.py	34	0	100%
expense_categories.py	6	0	100%
expense_reports.py	61	2	97%	40, 48
files.py	23	0	100%
folders.py	17	0	100%
items.py	12	0	100%
journal_entries.py	41	0	100%
locations.py	6	0	100%
price_level.py	6	0	100%
projects.py	6	0	100%
subsidiaries.py	6	0	100%
tax_groups.py	6	0	100%
tax_items.py	6	0	100%
vendor_bills.py	55	1	98%	89
vendor_payments.py	46	1	98%	41
vendors.py	21	0	100%
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	2	0	100%
helpers.py	13	1	92%	20
parser.py	24	11	54%	11–24
netsuitesdk/internal
__init__.py	0	0	100%
client.py	312	84	73%	75, 114–115, 133–134, 147, 154–155, 162–163, 166–188, 210, 217–225, 245–248, 280, 285–291, 323, 326–329, 353, 355, 358–359, 380, 415–416, 421, 467–471, 485–486, 517–525, 546–555, 604, 608, 620–621
constants.py	4	0	100%
exceptions.py	16	3	81%	24–26
netsuite_types.py	2	0	100%
utils.py	40	4	90%	34, 52, 63, 65
TOTAL	1013	116	89%

Tests	Skipped	Failures	Errors	Time
102	11 💤	1 ❌	0 🔥	3m 40s ⏱️

github-actions · 2023-05-26T09:31:31Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	0	100%
connection.py	70	0	100%
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	0	100%
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	9	90%	26–33, 43–44, 56, 85, 103, 121–122
classifications.py	6	0	100%
currencies.py	10	0	100%
custom_record_types.py	11	0	100%
custom_records.py	17	0	100%
customers.py	21	0	100%
departments.py	6	0	100%
employees.py	34	0	100%
expense_categories.py	6	0	100%
expense_reports.py	61	2	97%	40, 48
files.py	23	0	100%
folders.py	17	0	100%
items.py	12	0	100%
journal_entries.py	41	0	100%
locations.py	6	0	100%
price_level.py	6	0	100%
projects.py	6	0	100%
subsidiaries.py	6	0	100%
tax_groups.py	6	0	100%
tax_items.py	6	0	100%
vendor_bills.py	55	1	98%	89
vendor_payments.py	46	1	98%	41
vendors.py	21	0	100%
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	2	0	100%
helpers.py	13	1	92%	20
parser.py	24	11	54%	11–24
netsuitesdk/internal
__init__.py	0	0	100%
client.py	312	84	73%	75, 114–115, 133–134, 147, 154–155, 162–163, 166–188, 210, 217–225, 245–248, 280, 285–291, 323, 326–329, 353, 355, 358–359, 380, 415–416, 421, 467–471, 485–486, 517–525, 546–555, 604, 608, 620–621
constants.py	4	0	100%
exceptions.py	16	3	81%	24–26
netsuite_types.py	2	0	100%
utils.py	40	4	90%	34, 52, 63, 65
TOTAL	1013	116	89%

Tests	Skipped	Failures	Errors	Time
102	11 💤	1 ❌	0 🔥	3m 18s ⏱️

github-actions · 2023-05-26T09:36:46Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	0	100%
connection.py	70	0	100%
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	0	100%
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	9	90%	26–33, 43–44, 56, 85, 103, 121–122
classifications.py	6	0	100%
currencies.py	10	0	100%
custom_record_types.py	11	0	100%
custom_records.py	17	0	100%
customers.py	21	0	100%
departments.py	6	0	100%
employees.py	34	0	100%
expense_categories.py	6	0	100%
expense_reports.py	61	2	97%	40, 48
files.py	23	0	100%
folders.py	17	0	100%
items.py	12	0	100%
journal_entries.py	41	0	100%
locations.py	6	0	100%
price_level.py	6	0	100%
projects.py	6	0	100%
subsidiaries.py	6	0	100%
tax_groups.py	6	0	100%
tax_items.py	6	0	100%
vendor_bills.py	55	1	98%	89
vendor_payments.py	46	1	98%	41
vendors.py	21	0	100%
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	2	0	100%
helpers.py	13	1	92%	20
parser.py	24	11	54%	11–24
netsuitesdk/internal
__init__.py	0	0	100%
client.py	312	84	73%	75, 114–115, 133–134, 147, 154–155, 162–163, 166–188, 210, 217–225, 245–248, 280, 285–291, 323, 326–329, 353, 355, 358–359, 380, 415–416, 421, 467–471, 485–486, 517–525, 546–555, 604, 608, 620–621
constants.py	4	0	100%
exceptions.py	16	3	81%	24–26
netsuite_types.py	2	0	100%
utils.py	40	4	90%	34, 52, 63, 65
TOTAL	1013	116	89%

Tests	Skipped	Failures	Errors	Time
102	11 💤	0 ❌	0 🔥	3m 45s ⏱️

Shwetabhk · 2023-05-29T07:11:14Z

netsuitesdk/api/expense_reports.py

@@ -97,5 +100,6 @@ def post(self, data) -> OrderedDict:
            er['entity'] = self.ns_client.RecordRef(**(data['entity']))

        logger.debug('able to create er = %s', er)
-        res = self.ns_client.upsert(er)
+        res = self.ns_client.upsert(er,  'er')


lets use full name instead of short forms

Suggested change

res = self.ns_client.upsert(er, 'er')

res = self.ns_client.upsert(er, 'expense_report')

github-actions · 2023-05-29T07:38:06Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	0	100%
connection.py	70	0	100%
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	0	100%
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	9	90%	26–33, 43–44, 56, 85, 103, 121–122
classifications.py	6	0	100%
currencies.py	10	0	100%
custom_record_types.py	11	0	100%
custom_records.py	17	0	100%
customers.py	21	0	100%
departments.py	6	0	100%
employees.py	34	0	100%
expense_categories.py	6	0	100%
expense_reports.py	61	2	97%	40, 48
files.py	23	0	100%
folders.py	17	0	100%
items.py	12	0	100%
journal_entries.py	41	0	100%
locations.py	6	0	100%
price_level.py	6	0	100%
projects.py	6	0	100%
subsidiaries.py	6	0	100%
tax_groups.py	6	0	100%
tax_items.py	6	0	100%
vendor_bills.py	69	0	100%
vendor_payments.py	46	1	98%	41
vendors.py	21	0	100%
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	2	0	100%
helpers.py	13	1	92%	20
parser.py	24	11	54%	11–24
netsuitesdk/internal
__init__.py	0	0	100%
client.py	312	84	73%	75, 114–115, 133–134, 147, 154–155, 162–163, 166–188, 210, 217–225, 245–248, 280, 285–291, 323, 326–329, 353, 355, 358–359, 380, 415–416, 421, 467–471, 485–486, 517–525, 546–555, 604, 608, 620–621
constants.py	4	0	100%
exceptions.py	16	3	81%	24–26
netsuite_types.py	2	0	100%
utils.py	40	4	90%	34, 52, 63, 65
TOTAL	1027	115	89%

Tests	Skipped	Failures	Errors	Time
102	11 💤	1 ❌	0 🔥	6m 40s ⏱️

github-actions · 2023-05-29T07:58:24Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	3	25%	2–14
connection.py	70	54	23%	17–81
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	1	83%	9
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	60	33%	15–16, 26–33, 36–40, 43–44, 50, 53, 56, 60, 63–64, 71, 78, 82–98, 102–114, 117–118, 121–122, 125–126, 129–131, 134–135, 138–140, 143–145
classifications.py	6	1	83%	8
currencies.py	10	3	70%	8, 11, 17
custom_record_types.py	11	11	0%	1–21
custom_records.py	17	17	0%	1–73
customers.py	21	21	0%	1–170
departments.py	6	1	83%	8
employees.py	34	27	21%	11, 14–52
expense_categories.py	6	6	0%	1–9
expense_reports.py	61	55	10%	9–105
files.py	23	23	0%	1–34
folders.py	17	17	0%	1–25
items.py	12	12	0%	1–24
journal_entries.py	41	29	29%	29–34, 37–43, 46–81
locations.py	6	1	83%	8
price_level.py	6	6	0%	1–8
projects.py	6	6	0%	1–8
subsidiaries.py	6	1	83%	9
tax_groups.py	6	6	0%	1–9
tax_items.py	6	6	0%	1–9
vendor_bills.py	69	59	14%	18, 21–27, 30–127
vendor_payments.py	46	46	0%	1–73
vendors.py	21	12	43%	96, 99–116
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	2	0	100%
helpers.py	13	8	38%	6–7, 11, 15–20
parser.py	24	18	25%	7, 11–24, 29–35
netsuitesdk/internal
__init__.py	0	0	100%
client.py	312	257	18%	60–92, 96, 103–119, 122–138, 144, 147, 150–155, 158–163, 166–188, 206–228, 231–255, 272–276, 280, 283–291, 294–304, 318–333, 343–359, 374–390, 405–416, 419–425, 428–436, 455–471, 474–486, 507–525, 544–555, 602–621
constants.py	4	0	100%
exceptions.py	16	5	69%	20–21, 24–26
netsuite_types.py	2	0	100%
utils.py	40	23	42%	18–26, 30, 34, 38, 42, 46, 50–52, 56, 62–66
TOTAL	1027	795	23%

Tests	Skipped	Failures	Errors	Time
1	0 💤	0 ❌	1 🔥	1.431s ⏱️

github-actions · 2023-05-29T08:04:12Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	0	100%
connection.py	70	0	100%
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	0	100%
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	9	90%	26–33, 43–44, 56, 85, 103, 121–122
classifications.py	6	0	100%
currencies.py	10	0	100%
custom_record_types.py	11	0	100%
custom_records.py	17	0	100%
customers.py	21	0	100%
departments.py	6	0	100%
employees.py	34	0	100%
expense_categories.py	6	0	100%
expense_reports.py	58	2	97%	38, 46
files.py	23	0	100%
folders.py	17	0	100%
items.py	12	0	100%
journal_entries.py	41	0	100%
locations.py	6	0	100%
price_level.py	6	0	100%
projects.py	6	0	100%
subsidiaries.py	6	0	100%
tax_groups.py	6	0	100%
tax_items.py	6	0	100%
vendor_bills.py	69	0	100%
vendor_payments.py	46	1	98%	41
vendors.py	21	0	100%
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	2	0	100%
helpers.py	13	1	92%	20
parser.py	24	11	54%	11–24
netsuitesdk/internal
__init__.py	0	0	100%
client.py	312	84	73%	75, 114–115, 133–134, 147, 154–155, 162–163, 166–188, 210, 217–225, 245–248, 280, 285–291, 323, 326–329, 353, 355, 358–359, 380, 415–416, 421, 467–471, 485–486, 517–525, 546–555, 604, 608, 620–621
constants.py	4	0	100%
exceptions.py	16	3	81%	24–26
netsuite_types.py	2	0	100%
utils.py	40	4	90%	34, 52, 63, 65
TOTAL	1024	115	89%

Tests	Skipped	Failures	Errors	Time
102	11 💤	1 ❌	0 🔥	3m 50s ⏱️

github-actions · 2023-05-29T08:12:39Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	0	100%
connection.py	70	0	100%
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	0	100%
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	9	90%	26–33, 43–44, 56, 85, 103, 121–122
classifications.py	6	0	100%
currencies.py	10	0	100%
custom_record_types.py	11	0	100%
custom_records.py	17	0	100%
customers.py	21	0	100%
departments.py	6	0	100%
employees.py	34	0	100%
expense_categories.py	6	0	100%
expense_reports.py	58	2	97%	38, 46
files.py	23	0	100%
folders.py	17	0	100%
items.py	12	0	100%
journal_entries.py	41	0	100%
locations.py	6	0	100%
price_level.py	6	0	100%
projects.py	6	0	100%
subsidiaries.py	6	0	100%
tax_groups.py	6	0	100%
tax_items.py	6	0	100%
vendor_bills.py	69	0	100%
vendor_payments.py	46	1	98%	41
vendors.py	21	0	100%
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	2	0	100%
helpers.py	13	1	92%	20
parser.py	24	11	54%	11–24
netsuitesdk/internal
__init__.py	0	0	100%
client.py	312	84	73%	75, 114–115, 133–134, 147, 154–155, 162–163, 166–188, 210, 217–225, 245–248, 280, 285–291, 323, 326–329, 353, 355, 358–359, 380, 415–416, 421, 467–471, 485–486, 517–525, 546–555, 604, 608, 620–621
constants.py	4	0	100%
exceptions.py	16	3	81%	24–26
netsuite_types.py	2	0	100%
utils.py	40	4	90%	34, 52, 63, 65
TOTAL	1024	115	89%

Tests	Skipped	Failures	Errors	Time
102	11 💤	2 ❌	0 🔥	3m 58s ⏱️

github-actions · 2023-05-29T08:19:59Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	0	100%
connection.py	70	0	100%
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	0	100%
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	9	90%	26–33, 43–44, 56, 85, 103, 121–122
classifications.py	6	0	100%
currencies.py	10	0	100%
custom_record_types.py	11	0	100%
custom_records.py	17	0	100%
customers.py	21	0	100%
departments.py	6	0	100%
employees.py	34	0	100%
expense_categories.py	6	0	100%
expense_reports.py	58	2	97%	38, 46
files.py	23	0	100%
folders.py	17	0	100%
items.py	12	0	100%
journal_entries.py	41	0	100%
locations.py	6	0	100%
price_level.py	6	0	100%
projects.py	6	0	100%
subsidiaries.py	6	0	100%
tax_groups.py	6	0	100%
tax_items.py	6	0	100%
vendor_bills.py	69	0	100%
vendor_payments.py	46	1	98%	41
vendors.py	21	0	100%
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	2	0	100%
helpers.py	13	1	92%	20
parser.py	24	11	54%	11–24
netsuitesdk/internal
__init__.py	0	0	100%
client.py	312	84	73%	75, 114–115, 133–134, 147, 154–155, 162–163, 166–188, 210, 217–225, 245–248, 280, 285–291, 323, 326–329, 353, 355, 358–359, 380, 415–416, 421, 467–471, 485–486, 517–525, 546–555, 604, 608, 620–621
constants.py	4	0	100%
exceptions.py	16	3	81%	24–26
netsuite_types.py	2	0	100%
utils.py	40	4	90%	34, 52, 63, 65
TOTAL	1024	115	89%

Tests	Skipped	Failures	Errors	Time
102	11 💤	0 ❌	0 🔥	4m 21s ⏱️

github-actions · 2023-05-29T10:51:48Z

Coverage Report

File	Stmts	Miss	Cover	Missing
netsuitesdk
__init__.py	4	0	100%
connection.py	70	0	100%
netsuitesdk/api
__init__.py	0	0	100%
accounts.py	6	0	100%
adv_inter_company_journal_entries.py	7	0	100%
base.py	90	9	90%	26–33, 43–44, 56, 85, 103, 121–122
classifications.py	6	0	100%
currencies.py	10	0	100%
custom_record_types.py	11	0	100%
custom_records.py	17	0	100%
customers.py	21	0	100%
departments.py	6	0	100%
employees.py	34	0	100%
expense_categories.py	6	0	100%
expense_reports.py	58	2	97%	38, 46
files.py	23	0	100%
folders.py	17	0	100%
items.py	12	0	100%
journal_entries.py	41	0	100%
locations.py	6	0	100%
price_level.py	6	0	100%
projects.py	6	0	100%
subsidiaries.py	6	0	100%
tax_groups.py	6	0	100%
tax_items.py	6	0	100%
vendor_bills.py	69	0	100%
vendor_payments.py	46	1	98%	41
vendors.py	21	0	100%
netsuitesdk/errors
__init__.py	0	0	100%
errors.py	2	0	100%
helpers.py	13	1	92%	20
parser.py	24	4	83%	17–18, 21–22
netsuitesdk/internal
__init__.py	0	0	100%
client.py	312	77	75%	75, 114–115, 133–134, 147, 154–155, 162–163, 166–188, 210, 217–225, 245–248, 280, 285–291, 323, 326–329, 353, 355, 358–359, 380, 415–416, 421, 467–471, 485–486, 546–555, 604, 608, 620–621
constants.py	4	0	100%
exceptions.py	16	3	81%	24–26
netsuite_types.py	2	0	100%
utils.py	40	4	90%	34, 52, 63, 65
TOTAL	1024	101	90%

Tests	Skipped	Failures	Errors	Time
103	11 💤	0 ❌	0 🔥	3m 26s ⏱️

feature: support of error parser for expense report export

31f9e49

NileshPant1999 had a problem deploying to CI Environment May 16, 2023 10:07 — with GitHub Actions Failure

test fix

ce8481b

NileshPant1999 temporarily deployed to CI Environment May 16, 2023 10:10 — with GitHub Actions Inactive

beautify netsuite errors

b288c3f

NileshPant1999 temporarily deployed to CI Environment May 24, 2023 15:20 — with GitHub Actions Inactive

minor fix

b5a2c03

NileshPant1999 temporarily deployed to CI Environment May 24, 2023 15:44 — with GitHub Actions Inactive

NileshPant1999 requested a review from Shwetabhk May 24, 2023 19:22

NileshPant1999 commented May 25, 2023

View reviewed changes

add more errors

30b7b4a

NileshPant1999 had a problem deploying to CI Environment May 25, 2023 06:42 — with GitHub Actions Failure

Shwetabhk reviewed May 25, 2023

View reviewed changes

minor change

8aa7b4e

NileshPant1999 had a problem deploying to CI Environment May 25, 2023 09:30 — with GitHub Actions Failure

kik

56edf68

NileshPant1999 had a problem deploying to CI Environment May 25, 2023 09:33 — with GitHub Actions Failure

iuyg

09b3473

NileshPant1999 temporarily deployed to CI Environment May 25, 2023 09:35 — with GitHub Actions Inactive

NileshPant1999 added 2 commits May 25, 2023 15:07

Merge branch 'master' of https://github.com/fylein/netsuite-sdk-py in…

8edb3ff

…to parse-netsuite-error

bump up version

7c86741

NileshPant1999 temporarily deployed to CI Environment May 25, 2023 09:38 — with GitHub Actions Inactive

NileshPant1999 had a problem deploying to CI Environment May 26, 2023 09:21 — with GitHub Actions Failure

ad

24e56f9

NileshPant1999 had a problem deploying to CI Environment May 26, 2023 09:27 — with GitHub Actions Failure

ad

c40803c

NileshPant1999 temporarily deployed to CI Environment May 26, 2023 09:32 — with GitHub Actions Inactive

Shwetabhk reviewed May 29, 2023

View reviewed changes

Shwetabhk approved these changes May 29, 2023

View reviewed changes

conflict fix

93fcf2c

NileshPant1999 had a problem deploying to CI Environment May 29, 2023 07:31 — with GitHub Actions Failure

test fix

42dd6f9

NileshPant1999 had a problem deploying to CI Environment May 29, 2023 07:58 — with GitHub Actions Failure

asd

cef0812

NileshPant1999 had a problem deploying to CI Environment May 29, 2023 08:00 — with GitHub Actions Failure

sdf

42b6777

NileshPant1999 had a problem deploying to CI Environment May 29, 2023 08:08 — with GitHub Actions Failure

test fixed

811c7b8

NileshPant1999 temporarily deployed to CI Environment May 29, 2023 08:15 — with GitHub Actions Inactive

added tests

f7fb31b

NileshPant1999 temporarily deployed to CI Environment May 29, 2023 10:48 — with GitHub Actions Inactive

NileshPant1999 merged commit bafb51a into master May 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: support of error parser for expense report export #113

feature: support of error parser for expense report export #113

NileshPant1999 commented May 16, 2023

github-actions bot commented May 16, 2023

github-actions bot commented May 16, 2023

github-actions bot commented May 24, 2023

github-actions bot commented May 24, 2023

NileshPant1999 May 25, 2023 •

edited

Loading

github-actions bot commented May 25, 2023

Shwetabhk May 25, 2023

github-actions bot commented May 25, 2023

github-actions bot commented May 25, 2023

github-actions bot commented May 25, 2023

github-actions bot commented May 26, 2023

github-actions bot commented May 26, 2023

github-actions bot commented May 26, 2023

github-actions bot commented May 26, 2023

Shwetabhk May 29, 2023

github-actions bot commented May 29, 2023

github-actions bot commented May 29, 2023

github-actions bot commented May 29, 2023

github-actions bot commented May 29, 2023

github-actions bot commented May 29, 2023

github-actions bot commented May 29, 2023

		from .helpers import decode_project_or_customer_name, replace_numbers


		def expense_report_error_parser(error_dict, ns_client, message):

	res = self.ns_client.upsert(er, 'er')
	res = self.ns_client.upsert(er, 'expense_report')

feature: support of error parser for expense report export #113

feature: support of error parser for expense report export #113

Conversation

NileshPant1999 commented May 16, 2023

github-actions bot commented May 16, 2023

github-actions bot commented May 16, 2023

github-actions bot commented May 24, 2023

github-actions bot commented May 24, 2023

NileshPant1999 May 25, 2023 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented May 25, 2023

Shwetabhk May 25, 2023

Choose a reason for hiding this comment

github-actions bot commented May 25, 2023

github-actions bot commented May 25, 2023

github-actions bot commented May 25, 2023

github-actions bot commented May 26, 2023

github-actions bot commented May 26, 2023

github-actions bot commented May 26, 2023

github-actions bot commented May 26, 2023

Shwetabhk May 29, 2023

Choose a reason for hiding this comment

github-actions bot commented May 29, 2023

github-actions bot commented May 29, 2023

github-actions bot commented May 29, 2023

github-actions bot commented May 29, 2023

github-actions bot commented May 29, 2023

github-actions bot commented May 29, 2023

NileshPant1999 May 25, 2023 •

edited

Loading