making expenses optional and adding items support for vendor_bill (#115)

* making expenses optional and adding items support for vendor_bill

* adding test

netsuitesdk/api/vendor_bills.py

@@ -29,34 +29,68 @@ def get_all_generator(self):
     def post(self, data) -> OrderedDict:
         assert data['externalId'], 'missing external id'
         vb = self.ns_client.VendorBill(externalId=data['externalId'])
-        expense_list = []
-        for eod in data['expenseList']:
-            if 'customFieldList' in eod and eod['customFieldList']:
-                custom_fields = []
-                for field in eod['customFieldList']:
-                    if field['type'] == 'String':
-                        custom_fields.append(
-                            self.ns_client.StringCustomFieldRef(
-                                scriptId=field['scriptId'] if 'scriptId' in field else None,
-                                internalId=field['internalId'] if 'internalId' in field else None,
-                                value=field['value']
+        # If expesess are present, add them 
+        if 'expenseList' in data and data['expenseList']:
+            expense_list = []
+            for eod in data['expenseList']:
+                if 'customFieldList' in eod and eod['customFieldList']:
+                    custom_fields = []
+                    for field in eod['customFieldList']:
+                        if field['type'] == 'String':
+                            custom_fields.append(
+                                self.ns_client.StringCustomFieldRef(
+                                    scriptId=field['scriptId'] if 'scriptId' in field else None,
+                                    internalId=field['internalId'] if 'internalId' in field else None,
+                                    value=field['value']
+                                )
+                            )
+                        elif field['type'] == 'Select':
+                            custom_fields.append(
+                                self.ns_client.SelectCustomFieldRef(
+                                    scriptId=field['scriptId'] if 'scriptId' in field else None,
+                                    internalId=field['internalId'] if 'internalId' in field else None,
+                                    value=self.ns_client.ListOrRecordRef(
+                                        internalId=field['value']
+                                    )
+                                )
                             )
-                        )
-                    elif field['type'] == 'Select':
-                        custom_fields.append(
-                            self.ns_client.SelectCustomFieldRef(
-                                scriptId=field['scriptId'] if 'scriptId' in field else None,
-                                internalId=field['internalId'] if 'internalId' in field else None,
-                                value=self.ns_client.ListOrRecordRef(
-                                    internalId=field['value']
+                    eod['customFieldList'] = self.ns_client.CustomFieldList(custom_fields)
+                vbe = self.ns_client.VendorBillExpense(**eod)
+                expense_list.append(vbe)
+
+            vb['expenseList'] = self.ns_client.VendorBillExpenseList(expense=expense_list)
+
+        # If items are present, add them
+        if 'itemList' in data and data['itemList']:
+            item_list = []
+            for eod in data['itemList']:
+                if 'customFieldList' in eod and eod['customFieldList']:
+                    custom_fields = []
+                    for field in eod['customFieldList']:
+                        print(field['value'])
+                        if field['type'] == 'String':
+                            custom_fields.append(
+                                self.ns_client.StringCustomFieldRef(
+                                    scriptId=field['scriptId'] if 'scriptId' in field else None,
+                                    internalId=field['internalId'] if 'internalId' in field else None,
+                                    value=field['value']
                                 )
                             )
-                        )
-                eod['customFieldList'] = self.ns_client.CustomFieldList(custom_fields)
-            vbe = self.ns_client.VendorBillExpense(**eod)
-            expense_list.append(vbe)
-
-        vb['expenseList'] = self.ns_client.VendorBillExpenseList(expense=expense_list)
+                        elif field['type'] == 'Select':
+                            custom_fields.append(
+                                self.ns_client.SelectCustomFieldRef(
+                                    scriptId=field['scriptId'] if 'scriptId' in field else None,
+                                    internalId=field['internalId'] if 'internalId' in field else None,
+                                    value=self.ns_client.ListOrRecordRef(
+                                        internalId=field['value']
+                                    )
+                                )
+                            )
+                    eod['customFieldList'] = self.ns_client.CustomFieldList(custom_fields)
+                vbe = self.ns_client.VendorBillItem(**eod)
+                item_list.append(vbe)
+
+            vb['itemList']= self.ns_client.VendorBillItemList(item=item_list)
 
         if 'currency' in data:
             vb['currency'] = self.ns_client.RecordRef(**(data['currency']))
@@ -82,9 +116,6 @@ def post(self, data) -> OrderedDict:
         if 'account' in data:
             vb['account'] = self.ns_client.RecordRef(**(data['account']))
 
-        if 'itemList' in data:
-            vb['itemList'] = data['itemList']
-
         if 'customFieldList' in data:
             vb['customFieldList'] = data['customFieldList']
 

setup.py

@@ -5,7 +5,7 @@
 
 setuptools.setup(
     name='netsuitesdk',
-    version='2.17.0',
+    version='2.17.1',
     author='Siva Narayanan',
     author_email='[email protected]',
     description='Python SDK for accessing the NetSuite SOAP webservice',