Skip to content

Commit

Permalink
adjustable page size for employees generator (#123)
Browse files Browse the repository at this point in the history
  • Loading branch information
Shwetabhk authored Aug 29, 2023
1 parent 99d9884 commit 6e7ed74
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions netsuitesdk/api/employees.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class Employees(ApiBase):
def __init__(self, ns_client):
ApiBase.__init__(self, ns_client=ns_client, type_name='Employee')

def get_all_generator(self, is_inactive=False, last_modified_date_query={
def get_all_generator(self, is_inactive=False, page_size=50, last_modified_date_query={

This comment has been minimized.

Copy link
@DylanDylanCode

DylanDylanCode Nov 15, 2023

Hey there I'm not sure if it's related to this MR but for some reason when I run employees = nc.employees.get_all() I have come out the below error, any thoughts?

TypeError: 'set' object is not subscriptable

'search_value',
'operator',
}):
Expand All @@ -37,7 +37,7 @@ def get_all_generator(self, is_inactive=False, last_modified_date_query={
client=self.ns_client,
type_name='Employee',
basic_search=basic_search,
pageSize=500
pageSize=page_size
)

return self._paginated_search_generator(paginated_search=paginated_search)
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

setuptools.setup(
name='netsuitesdk',
version='2.20.0',
version='2.21.0',
author='Siva Narayanan',
author_email='[email protected]',
description='Python SDK for accessing the NetSuite SOAP webservice',
Expand Down

0 comments on commit 6e7ed74

Please sign in to comment.