Fix bug for when the first char is non-ascii char #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, good catch! Now that I'm looking at that line, I'm wondering why I didn't just check the first character directly against the range of valid characters ( What do you think? |
Crashes with: Index 258 out of bounds for length 256 java.lang.ArrayIndexOutOfBoundsException: Index 258 out of bounds for length 256 This changes the check for first char with a direct range check.
aleris
force-pushed
the
fix_lookup_non_ascii
branch
from
85d486e to
043b0aa
Compare
|
you are right :) updated |
|
Thanks again :) I will push a new release later today. |
fxlae
approved these changes
May 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crashes with:
Index 258 out of bounds for length 256
java.lang.ArrayIndexOutOfBoundsException:
Index 258 out of bounds for length 256
This adds a check for bigger SUFFIX_LOOKUP.length indexes for the first char.