WIP: Make operations on named pipes more consistent #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've fixed the behaviour and also found that we forgot to set standard pipes to non-blocking mode. Seems like we should have noticed this before, so a review and some further tests are needed. 👀 |
ssailer
reviewed
Aug 21, 2024
…new data after the writer hung up! Fix macOS return codes for that case.
…ways for TCP connections in CLOSE_WAIT and pipes where the writer hung up. Neat.
…en reading a stream from zstd -d. Mmmh...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to add explicit tests for named pipes.
Two issues have been identified so far:
bufio_read, see the test added in 271899e.