Fix whitespace in path crashes the server #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
reviewed
May 20, 2020
| @@ -1,8 +1,9 @@ | |||
| package org.javacs.kt.util | |||
|
|
|||
| import java.nio.charset.StandardCharsets | |||
| import org.eclipse.core.runtime.URIUtil | |||
There was a problem hiding this comment.
Is there a way to get this URI conversion behavior without pulling in a new dependency on the Eclipse runtime?
There was a problem hiding this comment.
I tried to write the conversion code myself but then I realized URI are more complicated that I thought (Like Datetime 😉). This is the source code for URIUtil.fromString.
There was a problem hiding this comment.
Are there other characters than spaces that we would have to handle? If not, we could just do a replacement of spaces by %20.
This seems to be a somewhat common issue.
This was referenced Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #200,
This PR fixes the whitespace issue that results crashing the server at initialization phase.