Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Why 1.1.1 #212

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Update to Why 1.1.1 #212

merged 2 commits into from
Jun 23, 2022

Conversation

keastrid
Copy link
Contributor

@keastrid keastrid commented Jun 19, 2022

  • Allow launcher to handle unpacked jars
  • Properly resolve relative paths for setting dll path
  • Add current directory fallback even why JRE location was specified
  • Change JVM discovery to lazy load the paths

Also implements the setting of some exe metadata.

PS if you need something changed in Why feel free to let me know.

@fvarrui fvarrui merged commit 20f6798 into fvarrui:devel Jun 23, 2022
@fvarrui
Copy link
Owner

fvarrui commented Jun 23, 2022

Thanks so much! Is it possible to run JavaLauncher using --module-path and --module arguments instead of --class-path? I'm thinking of adding support for JPMS.

@keastrid keastrid deleted the why_1.1.1 branch June 23, 2022 23:07
@keastrid
Copy link
Contributor Author

Sure! do you have a test project/jar? I've never used JPMS before, so I'll have to read up on it a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants