Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging failed with multi-release jar #2

Closed
Pyeroh opened this issue Oct 1, 2019 · 3 comments
Closed

Packaging failed with multi-release jar #2

Pyeroh opened this issue Oct 1, 2019 · 3 comments

Comments

@Pyeroh
Copy link
Contributor

Pyeroh commented Oct 1, 2019

When packaging with a multi-release jar, I get a NPE from your plugin.
I'm using Maven, the faulty library is H2 (which is now multi-release), and when the plugin runs jeps, it gets an error, because h2-1.4.199.jar is a multi-release jar file but --multi-release option is not set.
Then jlink is called with that message, which is obviously not a valid modules list, and the jre folder is not created by jlink. Hence the NPE.

I tried to run the jdeps command on my machine, with the multi-release option, and it returns modules names.

BTW, thank you very much for this plugin, it does its jobs perfectly ! I spent too much time trying to fit my JavaFX/"Java 8 only libraries" app in the module system, and kept failing. It makes it work like a breeze !

@fvarrui
Copy link
Owner

fvarrui commented Oct 1, 2019

Please, could you provide me with a sample project repo where you use a multi-release jar? Thanks for giving a try to JavaPackager.

@fvarrui fvarrui closed this as completed in 0a91b61 Oct 1, 2019
@fvarrui
Copy link
Owner

fvarrui commented Oct 1, 2019

I added --multi-release option to jdeps command using current JRE version as its value by default, then tried with h2-1.4.199.jar jar file and now it doesn't fail. Could you confirm me if this issue is really solved? Thanks!

@Pyeroh
Copy link
Contributor Author

Pyeroh commented Oct 1, 2019

It's solved indeed, thank you very much !

fvarrui added a commit that referenced this issue Mar 6, 2020
fvarrui added a commit that referenced this issue Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants