worked on #2 fixes, CRM-14052

---------------------------------------- * CRM-14052: Tagset fixes http://issues.civicrm.org/jira/browse/CRM-14052
fuzionnz · Jan 6, 2014 · b3caa3a · b3caa3a
1 parent 0cc0faa
commit b3caa3a
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/CRM/Admin/Page/AJAX.php b/CRM/Admin/Page/AJAX.php
@@ -404,7 +404,7 @@ static function processTags() {
       if (!is_numeric($tagID)) {
         $tagID = CRM_Core_DAO::getFieldValue('CRM_Core_DAO_Tag', $tagID, 'id', 'name');
       }
-      if ($entityId) {
+      if (!$skipEntityAction && $entityId) {
         // delete this tag entry for the entity
         $params = array(
           'entity_table' => $entityTable,

diff --git a/CRM/Core/Form/Tag.php b/CRM/Core/Form/Tag.php
@@ -236,6 +236,7 @@ static function buildQuickForm(&$form, $parentNames, $entityTable, $entityId = N
    *
    */
   static function postProcess(&$params, $entityId, $entityTable = 'civicrm_contact', &$form) {
+    $allTagIds = array();
     foreach ($params as $parentId => $value) {
       if (!$value) {
         continue;
@@ -260,6 +261,7 @@ static function postProcess(&$params, $entityId, $entityTable = 'civicrm_contact
             }
           }
 
+          $allTagIds[] = $tagId;
           if ($form && $form->_action != CRM_Core_Action::UPDATE) {
             $insertValues[] = "( {$tagId}, {$entityId}, '{$entityTable}' ) ";
           }
@@ -274,6 +276,14 @@ static function postProcess(&$params, $entityId, $entityTable = 'civicrm_contact
         }
       }
     }
+
+    // delete tags that are missing
+    if (!empty($allTagIds)) {
+      $validTagIds = implode(',', $allTagIds);
+      $deleteSQL = "DELETE FROM civicrm_entity_tag WHERE entity_id={$entityId} AND entity_table='{$entityTable}'
+      AND tag_id NOT IN ({$validTagIds})";
+      CRM_Core_DAO::executeQuery($deleteSQL);
+    }
   }
 }
 
diff --git a/templates/CRM/common/Tag.tpl b/templates/CRM/common/Tag.tpl
@@ -63,7 +63,9 @@
                         setVal[x] = valArray[x];
                       }
                     }
-                    CRM.alert('', '{/literal}{ts escape='js'}Removed{/ts}{literal}', 'success');
+                    if (!skipEntityAction) {
+                      CRM.alert('', '{/literal}{ts escape='js'}Removed{/ts}{literal}', 'success');
+                    }
                   }
                   else {
                     CRM.alert('', '{/literal}{ts escape='js'}Saved{/ts}{literal}', 'success');