wip

contracts/payments/Ticketing.sol

@@ -129,13 +129,11 @@ contract Ticketing is ITicketing, Initializable, Ownable2StepUpgradeable, ERC165
     error TicketAlreadyRedeemed();
     error RedeemerCommitMismatch();
     error InvalidSignature();
-    error TokenCannotBeZeroAddress();
-    error TicketNotCreatedInTheEpoch();
+    error TokenAddressCannotBeNil();
     error TicketCannotBeFromFutureBlock();
     error TicketSenderCannotBeZeroAddress();
     error TicketReceiverCannotBeZeroAddress();
     error TicketRedeemerCannotBeZeroAddress();
-    error RedeemerMustHaveJoinedEpoch(uint256 cycle);
 
     function initialize(
         IERC20 token,
@@ -152,7 +150,7 @@ contract Ticketing is ITicketing, Initializable, Ownable2StepUpgradeable, ERC165
         uint256 _ticketDuration
     ) external initializer {
         if (address(token) == address(0)) {
-            revert TokenCannotBeZeroAddress();
+            revert TokenAddressCannotBeNil();
         }
 
         Ownable2StepUpgradeable.__Ownable2Step_init();

test/paymets/deposits.test.ts

@@ -4,9 +4,8 @@ import { deployContracts, getBlockNumber, MAX, MAX_SYLO } from '../utils';
 import { Signer } from 'ethers';
 import { expect, assert } from 'chai';
 import { Deposits } from '../../typechain-types';
-import { increase } from '@nomicfoundation/hardhat-network-helpers/dist/src/helpers/time';
 
-describe.only('Deposits', () => {
+describe('Deposits', () => {
   let accounts: Signer[];
   let contracts: SyloContracts;
   let deposits: Deposits;

test/paymets/ticketing.test.ts

@@ -1,11 +1,11 @@
 import { ethers } from 'hardhat';
 import { SyloContracts } from '../../common/contracts';
 import { deployContracts } from '../utils';
-import { Signer } from 'ethers';
+import { ContractTransactionResponse, Signer } from 'ethers';
 import { expect, assert } from 'chai';
 import { Deposits, Ticketing } from '../../typechain-types';
 
-describe('Ticketing', () => {
+describe.only('Ticketing', () => {
   let accounts: Signer[];
   let contracts: SyloContracts;
   let deposits: Deposits;
@@ -16,5 +16,90 @@ describe('Ticketing', () => {
     contracts = await deployContracts();
     deposits = contracts.deposits;
     ticketing = contracts.ticketing;
+
+    await deposits.approveTicketing(ticketing.getAddress());
+  });
+
+  it('cannot initialize deposits with invalid arguments', async () => {
+    const factory = await ethers.getContractFactory('Ticketing');
+    const ticketing = await factory.deploy();
+
+    await expect(
+      ticketing.initialize(
+        ethers.ZeroAddress,
+        ethers.ZeroAddress,
+        ethers.ZeroAddress,
+        ethers.ZeroAddress,
+        ethers.ZeroAddress,
+        ethers.ZeroAddress,
+        100n,
+        1n,
+        1n,
+        1n,
+        1n,
+        1n,
+      ),
+    ).to.be.revertedWithCustomError(deposits, 'TokenAddressCannotBeNil');
   });
+
+  it('can set ticketing parameters', async () => {
+    const updateParam = async <P>(
+      setter: (p: P) => Promise<ContractTransactionResponse>,
+      getter: () => Promise<P>,
+      value: P,
+      event: string,
+    ) => {
+      await expect(setter(value)).to.emit(ticketing, event);
+      await expect(await getter()).to.equal(value);
+
+      // confirm setter can only called by owner
+      // const nonOwnerCall = ticketing.connect(accounts[1]).
+    };
+
+    await updateParam(
+      ticketing.setFaceValue,
+      ticketing.faceValue,
+      111n,
+      'FaceValueUpdated',
+    );
+
+    await updateParam(
+      ticketing.setMultiReceiverFaceValue,
+      ticketing.multiReceiverFaceValue,
+      222n,
+      'MultiReceiverFaceValueUpdated',
+    );
+
+    await updateParam(
+      ticketing.setBaseLiveWinProb,
+      ticketing.baseLiveWinProb,
+      333n,
+      'BaseLiveWinProbUpdated',
+    );
+
+    await updateParam(
+      ticketing.setExpiredWinProb,
+      ticketing.expiredWinProb,
+      444n,
+      'ExpiredWinProbUpdated',
+    );
+
+    await updateParam(
+      ticketing.setDecayRate,
+      ticketing.decayRate,
+      555n,
+      'DecayRateUpdated',
+    );
+
+    await updateParam(
+      ticketing.setTicketDuration,
+      ticketing.ticketDuration,
+      666n,
+      'TicketDurationUpdated',
+    );
+  });
+
+  it('cannot set invalid ticketing parameters', async () => {});
+
+  it('cannot set ticketing parameters as non-owner', async () => {});
 });