Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for koin-annotations in peristence module. #68

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

matejsemancik
Copy link
Member

@matejsemancik matejsemancik commented May 28, 2024

After conversation and suggestions in InsertKoinIO/koin-annotations#105, it seems like there is a solution to our problem. I had to try the provided suggestions.

This PR adds support for KSP-generated Koin platform module in :shared:persistence Gradle module.

It seems to work, and upon inspection, the generated Koin modules in each target's source sets do really contain platform-specific dependencies. However, some issues arised from this solution:

  • Code completion in commonMain does not work, because the persistence module is generated in each target's source set instead of commonMain.

Screenshot 2024-05-28 at 8 51 19

  • I also had to ditch the koin-annotations convention plugin, as the KSP / annotations compiler refused to generate modules when using it (don't know why).

Adds support for KSP-generated Koin platform module & fixes KSP configuration in `":shared:persistence` Gradle module.
…uckery

# Conflicts:
#	gradle/libs.versions.toml
@matejsemancik matejsemancik marked this pull request as draft May 28, 2024 07:15
Copy link

Danger has errored

[!] Invalid Dangerfile file: �[31m
[!] Invalid Dangerfile file: swiftlint is not installed. Updating the Danger gem might fix the issue. Your Danger version: 8.6.1, latest Danger version: 9.4.3
�[0m

from /Users/runnerm1/.gem/ruby/3.2.2/gems/thefuntasty_danger-0.9.0/Dangerfile:56

-------------------------------------------

swiftlint.max_num_violations = 20

> swiftlint.lint_files inline_mode: true

end

-------------------------------------------

. Updating the Danger gem might fix the issue. Your Danger version: 8.6.1, latest Danger version: 9.4.3

 #  from /Users/runnerm1/.gem/ruby/3.2.2/gems/thefuntasty_danger-0.9.0/Dangerfile:56
 #  -------------------------------------------
 #   >   #  
 #  -------------------------------------------

Generated by 🚫 Danger

@matejsemancik matejsemancik changed the base branch from main to develop June 10, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant