Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove replace directive in go.mod for open-policy-agent/opa #2036

Closed
shino opened this issue Sep 30, 2024 · 2 comments · Fixed by #2044
Closed

Remove replace directive in go.mod for open-policy-agent/opa #2036

shino opened this issue Sep 30, 2024 · 2 comments · Fixed by #2044

Comments

@shino
Copy link
Collaborator

shino commented Sep 30, 2024

#2032 adds replace directive which is added to trivy at aquasecurity/trivy@870523d#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R424 to workaround performance issue aquasecurity/trivy#7431

replace github.com/open-policy-agent/opa => github.com/nikpivkin/opa v0.0.0-20240829080621-16999fcb5464

The performance issue will be fixed by aquasecurity/trivy#7435 (merged but not released yet at 2024-09-30).
The replace workaround should be removed after trivy including the fix is released.
@shino shino mentioned this issue Sep 30, 2024
Merged
12 tasks
@MaineK00n MaineK00n linked a pull request Oct 8, 2024 that will close this issue
chore(deps): bump github.com/aquasecurity/trivy from 0.55.2 to 0.56.1 #2044
Merged
@shino
Copy link
Collaborator Author

shino commented Oct 16, 2024

Oops, not fixed yet.

@shino shino reopened this Oct 16, 2024
shino added a commit that referenced this issue Oct 16, 2024
@shino
Remove replace directive
1e1deea 
See #2036
shino added a commit that referenced this issue Oct 16, 2024
@shino
Remove replace directive
a9ac5d2 
See #2036
shino added a commit that referenced this issue Oct 28, 2024
@dependabot @shino
chore(deps): bump github.com/aquasecurity/trivy from 0.56.1 to 0.56.2 (…
e396332 
…#2049)

* chore(deps): bump github.com/aquasecurity/trivy from 0.56.1 to 0.56.2

Bumps [github.com/aquasecurity/trivy](https://github.com/aquasecurity/trivy) from 0.56.1 to 0.56.2.
- [Release notes](https://github.com/aquasecurity/trivy/releases)
- [Changelog](https://github.com/aquasecurity/trivy/blob/v0.56.2/CHANGELOG.md)
- [Commits](aquasecurity/trivy@v0.56.1...v0.56.2)

---
updated-dependencies:
- dependency-name: github.com/aquasecurity/trivy
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Remove replace directive

See #2036

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shunichi Shinohara <[email protected]>
@shino
Copy link
Collaborator Author

shino commented Oct 29, 2024

done by https://github.com/future-architect/vuls/pull/2049/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6L371

@shino shino closed this as completed Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): bump github.com/aquasecurity/trivy from 0.55.2 to 0.56.1 future-architect/vuls
1 participant
@shino