-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Inbox Model Improvements #74
Draft
prolic
wants to merge
9
commits into
master
Choose a base branch
from
inbox_model
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reduce maxRelaysPerContact from 3 to 2 - Improve relay selection logic to better balance between shared and unique relays - When both shared and unique relays exist, select 1 shared + remaining unique - Maintain maxRelaysPerContact limit while prioritizing relay diversity
Giftwrap events (encrypted DMs) should only be subscribed to on DM relays, not inbox relays. Replace with appropriate subscriptions for mentions and profile/post data.
- excludes failed relays within last N days - Add connectWithFallback helper to handle relay connection failures - Cache relay lists to reduce LMDB calls using getRelayListsForPubkeys - Simplify buildRelayPubkeyMap to only use inbox relays as last resort
- Move subscription handling to dedicated SubscriptionHandler module - Add pagination support for subscriptions - Improve relay connection reliability with fallbacks and rebalancing - Refactor subscription state management and event processing - Add random relay selection from default pools - Fix PTag parsing to handle all tag variants - Move Main.hs to app/ directory
- Simplify subscription handling by removing redundant parameters - Add pagination limits based on number of pubkeys - Fix subscription cleanup to prevent premature state removal - Use maximum timestamp instead of minimum for better event ordering - Add proper handling of subscription state during relay updates - Fix hasOtherSubs check in DM subscriptions
… type: - Replace Tag constructors (ETag, PTag, etc) with list-based tags per NIP-01 - Move types into dedicated modules (Event, Profile, Relay) - Update tag parsing/generation throughout codebase - Simplify root/reply reference handling in UI
Improve relay connection state management, fix parsing of OK messages, update follow list and DM relay parsing, and add proper nevent links to quote reposts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should resolve #66 when done
major subscription and relay management overhaul