This repository has been archived by the owner on May 17, 2019. It is now read-only.
Ensure correct CI test exit status code #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtsao
force-pushed
the
ci-status-code
branch
from
4f5b313 to
09b5894
Compare
AlexMSmithCA
previously approved these changes
Dec 19, 2017
KevinGrandon
reviewed
Jan 3, 2018
.buildkite/nodeTests
Outdated
| @@ -1,3 +1,3 @@ | |||
| #!/usr/bin/env bash | |||
| ./node_modules/.bin/nyc --reporter=text --reporter=json node test/index.js | |||
| ./node_modules/.bin/nyc --reporter=text --reporter=json node dist-tests/node.js || exit 1 | |||
There was a problem hiding this comment.
This should probably be test/index.js still, right?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing coverage for now (running out of memory on buildkite boxes)