This repository has been archived by the owner on May 17, 2019. It is now read-only.
Add updateSnapshot CLI arg for updating snapshots #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 67.67% 67.48% -0.19%
==========================================
Files 69 69
Lines 1460 1464 +4
Branches 324 325 +1
==========================================
Hits 988 988
- Misses 417 421 +4
Partials 55 55
Continue to review full report at Codecov.
|
mlmorg
reviewed
Dec 15, 2017
| @@ -0,0 +1,3 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
There was a problem hiding this comment.
Possible to not have these comments in here? Having some non-jest-specific api for snapshot testing will allow us to change the underlying implementation in the future, if we want to.
There was a problem hiding this comment.
Looking into it, but I don't believe so. I bet we could codemod the snapshot engine though if needed.
KevinGrandon
force-pushed
the
snapshotting
branch
2 times, most recently
from
691fed0 to
d07192d
Compare
KevinGrandon
force-pushed
the
snapshotting
branch
from
d07192d to
b69f49e
Compare
KevinGrandon
changed the title
angus-c
approved these changes
Dec 16, 2017
|
!merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a CLI arg,
--updateSnapshotwhich will pass through to jest and update test snapshots.Fixes #68