This repository has been archived by the owner on May 17, 2019. It is now read-only.
Include shared entry file in tests for real coverage #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common issue with nyc/istanbul is the coverage only covers as far as the test entry points reach but not the whole bundle, giving a false sense of high coverage. Here's a similar issue describing the problem: gotwarlost/istanbul#112
--include-all-sources
inIstanbul v1
, now--all
inIstanbul v2/nyc
extends the coverage area to the whole bundle. However, our bundles including test bundles are tree-shaked, therefore the option won't save the situation.The changes here include shared entry point(currently
src/main.js
to test entry points passing to multi-entry-loaderOpen for comments, given this basically eliminates tree-shaking for test bundles.