Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Check the existence of the shared entry file #45

Merged
merged 2 commits into from
Dec 1, 2017
Merged

Check the existence of the shared entry file #45

merged 2 commits into from
Dec 1, 2017

Conversation

dennisgl
Copy link
Contributor

@dennisgl dennisgl commented Dec 1, 2017

fixes #44

@old-fusion-bot
Copy link

old-fusion-bot bot commented Dec 1, 2017

Found TODOs without GitHub issues:

fusion-cli/build/compiler.js

Line 121 in 2e0fd93

// TODO: use 'webpack/hot/signal' instead

fusion-cli/build/compiler.js

Line 129 in 2e0fd93

// TODO: Do we need to do something different here for production?

@dennisgl dennisgl changed the title check existence of the shared entry file check the existence of the shared entry file Dec 1, 2017
KevinGrandon
KevinGrandon previously approved these changes Dec 1, 2017
View reviewed changes
@dennisgl dennisgl changed the title check the existence of the shared entry file Check the existence of the shared entry file Dec 1, 2017
@dennisgl
Copy link
Contributor Author

dennisgl commented Dec 1, 2017

!merge

@old-fusion-bot old-fusion-bot bot merged commit 9823a2b into fusionjs:master Dec 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganemone ganemone ganemone approved these changes

@nadiia nadiia nadiia approved these changes

@KevinGrandon KevinGrandon KevinGrandon left review comments

@rtsao rtsao Awaiting requested review from rtsao

@lhorie lhorie Awaiting requested review from lhorie

@AlexMSmithCA AlexMSmithCA Awaiting requested review from AlexMSmithCA

@davidkearns davidkearns Awaiting requested review from davidkearns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check existence of the shared entry file
4 participants
@dennisgl @KevinGrandon @nadiia @ganemone