Implement pure annotation for createPlugin #287

KevinGrandon · 2018-03-20T20:28:46Z

Fixes #287

…tion

ganemone · 2018-03-20T22:12:53Z

test/fixtures/tree-shaking/src/main.js

 export default async function() {
  const app = new App('element', el => el);
+  __BROWSER__ && app.register(defaultExportBrowserPlugin);


I think it would be really useful to test named exports also.

Good idea, test added.

ganemone · 2018-03-20T22:13:09Z

test/fixtures/tree-shaking/src/plugins/instrumented-as-pure-node.js

@@ -0,0 +1,8 @@
+import {createPlugin} from 'fusion-core';
+
+const PLUGIN = /*@__PURE__*/ createPlugin({


What is the purpose of the instrumented as pure files?

Just thought it would be good to have a test case for this, in case that folks want to instrument their own code.

KevinGrandon force-pushed the webpack4-tree-shaking branch from 4c8588c to 14370d1 Compare March 20, 2018 21:37

WIP - Add webpack 4 tree shaking test

354af08

KevinGrandon force-pushed the webpack4-tree-shaking branch from 14370d1 to 354af08 Compare March 20, 2018 21:43

Giancarlo Anemone and others added 2 commits March 20, 2018 14:44

Add babel plugin for pure createPlugin comment

be9b2bf

Update plugin for babel7 transpilation changes, add plugin to compila…

16af5f4

…tion

KevinGrandon changed the title ~~WIP - Add webpack 4 tree shaking test~~ Implement pure annotation for createPlugin Mar 20, 2018

ganemone reviewed Mar 20, 2018

View reviewed changes

ganemone previously approved these changes Mar 20, 2018

View reviewed changes

Add named export tree shaking test

2aae560

KevinGrandon dismissed ganemone’s stale review via 2aae560 March 20, 2018 22:22

KevinGrandon merged commit 77fb9dc into fusionjs:master Mar 20, 2018

Provide feedback

		@@ -0,0 +1,8 @@
		import {createPlugin} from 'fusion-core';

		const PLUGIN = /@__PURE__/ createPlugin({