Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Upgrade to webpack@4 and babel@7 #281

Merged
merged 12 commits into from
Mar 17, 2018
Merged

Upgrade to webpack@4 and babel@7 #281

merged 12 commits into from
Mar 17, 2018

Conversation

KevinGrandon
Copy link
Contributor

This upgrades webpack to version 4 in a way that keeps things mostly the same as what's in master for the easiest possible upgrade. While it may be possible to update our usage of webpack plugins now that webpack 4 has new interfaces, decoupling the two efforts will allow us to move more quickly than doing everything at once.

Changes:

  • Update plugins to use new hook API interface.
  • Update tests to remove '-e' (causes webpack to infinitely re-bundle).
  • Update instrumented import plugin to use moduleNamespacePromise and chunkGroup interface.
  • Greenkeep dependencies.
  • Adds a test for named exports.

Test plan:

  • Ensure that existing tests pass.
  • Verify fusion-cli works in the browser-test repo.
  • Verify fusion-cli works in various boilerplate repos.
  • Inspect filesystem for expected dynamic import instrumented bundles.

Fixes #264

@KevinGrandon KevinGrandon changed the title WIP - Webpack4 (again) Upgrade to Webpack@4 again Mar 16, 2018
@KevinGrandon KevinGrandon changed the title Upgrade to Webpack@4 again Upgrade to webpack@4 and babel@7 Mar 16, 2018
ganemone
ganemone previously approved these changes Mar 16, 2018
@old-fusion-bot old-fusion-bot bot requested a deployment to production March 17, 2018 00:01 Abandoned
@KevinGrandon KevinGrandon merged commit 88fe6cb into master Mar 17, 2018
@KevinGrandon KevinGrandon deleted the webpack4 branch March 17, 2018 00:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants