This repository has been archived by the owner on May 17, 2019. It is now read-only.
Merge jsdom and node coverage results #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlmorg
reviewed
Jan 9, 2018
build/merge-coverage.js
Outdated
| env => | ||
| new Promise(resolve => { | ||
| const interval = setInterval(() => { | ||
| const coverageExists = fs.existsSync( |
There was a problem hiding this comment.
It looks like exists() is being deprecated, but existsSync() is not.
| const fs = require('fs'); | ||
|
|
||
| // Jest writes coverage after the process exits | ||
| // so we need to poll and wait for all coverage files. |
There was a problem hiding this comment.
What if there is an error and coverage is never written?
There was a problem hiding this comment.
The node process should just exit in this case, killing the CLI as well. I'll go ahead and include a timeout here though in case coverage never gets written for some reason.
mlmorg
reviewed
Jan 9, 2018
| @@ -1 +1 @@ | |||
| coverage/ | |||
| coverage*/ | |||
There was a problem hiding this comment.
We should make sure to make this change in the scaffold.
|
!merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates multiple coverage folders depending on what test suites are run (node, jsdom), and merges them after coverage is collected into a single coverage/ folder. There is some weirdness around the jest process exiting before coverage is done writing to disk, so we wait until expected coverage files are present before merging.
Fixes #121