This repository has been archived by the owner on May 17, 2019. It is now read-only.
Display SSR errors in the browser in dev mode #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinGrandon
changed the title
KevinGrandon
force-pushed
the
server_render_error_reporting
branch
from
c9fec50 to
b418b47
Compare
KevinGrandon
changed the title
KevinGrandon
force-pushed
the
server_render_error_reporting
branch
10 times, most recently
from
217964b to
e4a1b29
Compare
Currently we just display internal server error. Rendering the error in the browser should lead to a better developer UX. Refs fusionjs#108
KevinGrandon
force-pushed
the
server_render_error_reporting
branch
from
e4a1b29 to
1dc1648
Compare
rtsao
approved these changes
Jan 8, 2018
|
Thanks for fixing package.json. !merge |
|
!merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we just display internal server error. Rendering the error in the browser should lead to a better developer UX. Error screen looks like:
Refs #108