Fixed layout issue to prevent needing to replace WidgyPage

[zmetcalf]

@gavinwahl, I took what you gave on the google groups and added in a little bit with layout. What do you think?

I have a project I tried it out on here: https://github.com/zmetcalf/layout_issue

[zmetcalf]

@gavinwahl, do I need to put a try/except here because of the potential of an ImportError?

[gavinwahl]

I don't understand this owner_class thing

[zmetcalf]

In the valid_root_of method you provided, owner_class in the function only produces the widgy.contrib.widgy_mezzanine.models.WidgyPage, so it needs something to compare it to. I added in an owner_class property so it could tell the difference between a WIDGY_MEZZANINE_PAGE_MODEL and lets say a Blog model. Does that help?

[gavinwahl]

I was thinking it would look like this:

def valid_root_of(self, owner_class, root_class, root_choices):
    if isinstance(owner_class, WidgyPage):
        return isinstance(root_class, (YourLayout,))
    else:
        return super().valid_root_of(owner_class, root_class, root_choices)

Unrelated, I'm wonder why valid_root_of returns a boolean instead of having a root_choices_for that returns a list of possible roots.

[zmetcalf]

For the returning of booleans, I would say it is because the Generators function that calls it requires a boolean, not the actual list. I am not sure what you meant by root_choices_for

I will try putting the necessary logic in valid_root_of.

[zmetcalf]

@gavinwahl, I think I see where you are going with this. I kept it with just what you put on google groups, then I overrided site.py in my test project to make it work. https://github.com/zmetcalf/layout_issue/blob/master/widgy_demo/site.py

What do you think of adding in a setting?

def valid_root_of(self, owner_class, root_class, root_choices):
   if settings.WIDGY_MEZZANINE_LAYOUT_LIST:
        return issubclass(root_class, settings.WIDGY_MEZZANINE_LAYOUT_TUPEL)
    else: 
        return issubclass(root_class, root_choices)

[zmetcalf]

On your example, the second line will always return False. If it is changed to issubclass, it will always be true if there is no WIDGY_MEZZANINE_PAGE_MODEL declared, so it won't weed out a BlogLayout because owner_class just returns the active page model.

[zmetcalf]

@gavinwahl, sorry for being a mess. I updated the test project so it works now: https://github.com/zmetcalf/layout_issue/blob/master/widgy_demo/site.py

[rockymeza]

I think @gavinwahl means doing something like this:

def get_root_choices_for(self, owner_class):
    if issubclass(owner_class, WidgyPage):
        return ('myapp.MyBaseLayout',)
    else:
        return owner_class.root_node.root_choices

HOWEVER, what I just realized is that we are dealing with the owner_class, which is actually breaking one of our eventual use-cases of allowing a model to have multiple WidgyFields. This method and the valid_root_of as is don't support multiple WidgyFields.

[rockymeza]

I didn't mean to close it, sorry!

[zmetcalf]

No worries, I am going to close it anyway because it looks like you all need to figure out the future of owner_class. (and it is Gavin's code anyway)