Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved to src layout #85

Merged
merged 13 commits into from
Jan 17, 2024
Merged

moved to src layout #85

merged 13 commits into from
Jan 17, 2024

Conversation

shimwell
Copy link
Member

this PR changes the package to use the latest recommended python packaging approach with a src folder and pyproject.toml file.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d10f0c2) 95.96% compared to head (720ad68) 95.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files           7        7           
  Lines         347      347           
=======================================
  Hits          333      333           
  Misses         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shimwell
Copy link
Member Author

shimwell commented Jan 17, 2024

🎉 all the tests are passing. I got carried away and updated the CI as well as simplifying the examples. We no longer need nuclear data for the examples which speeds up the CI and makes the examples easier

@shimwell
Copy link
Member Author

This PR does not change the actual source code of the package so I think it is ok to merge in what do you think @RemDelaporteMathurin

@RemDelaporteMathurin
Copy link
Member

This PR does not change the actual source code of the package so I think it is ok to merge in what do you think @RemDelaporteMathurin

No problem with me!

@shimwell shimwell merged commit 878a8d2 into main Jan 17, 2024
4 checks passed
@shimwell shimwell deleted the update_package branch November 28, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants