Next openMC release

[RemDelaporteMathurin]

This is an attempt at fixing #80

[RemDelaporteMathurin]

@shimwell fully removing param stuff solves the failing tests in #172

However, the input checks are now fails but this is easy to fix.

[RemDelaporteMathurin]

@shimwell this is now ready for review.

In a nutshell, removed all param stuff and replaced with good old getters and setters methods.

[codecov]

Codecov Report

Merging #83 (3e69d9d) into main (0917dc9) will decrease coverage by 0.34%.
The diff coverage is 96.40%.

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   96.29%   95.96%   -0.34%     
==========================================
  Files           7        7              
  Lines         216      347     +131     
==========================================
+ Hits          208      333     +125     
- Misses          8       14       +6     

Impacted Files	Coverage Δ
openmc_plasma_source/tokamak_source.py	94.73% <92.85%> (-2.46%)	⬇️
openmc_plasma_source/fuel_types.py	100.00% <100.00%> (ø)
openmc_plasma_source/point_source.py	100.00% <100.00%> (ø)
openmc_plasma_source/ring_source.py	100.00% <100.00%> (ø)

[shimwell]

Thanks for maintaining this package Remi, the best part of this is the tokamak plasma source you made. Sadly I don't use this source much anymore but good to keep this package alive.

I shall review and perhaps we make a release after the next openmc release

[RemDelaporteMathurin]

Thanks for maintaining this package Remi, the best part of this is the tokamak plasma source you made. Sadly I don't use this source much anymore but good to keep this package alive.

I shall review and perhaps we make a release after the next openmc release

No problem. Maybe we can wait until the next openmc release and ping to a static version of the openmc image instead of develop.

[shimwell]

Nice PR, many thanks

I plan to follow this up with a PR that modernizes the install method and another one that checks the version of openmc used is >= 0.13.4

[RemDelaporteMathurin]

Oh so we're merging this now? the newest version of openmc hasn't been released yet though

[shimwell]

Oh sorry, I thought that was the plan. We don't make a PyPi release till the openmc release

[egor1abs]

Hello! What about updating package for OpenMC 0.14.0?

[shimwell]

thanks @egor1abs I've just made a releae of version 0.3.0
openmc-plasma-source